Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 2017 invoked from network); 8 Apr 2007 13:43:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Apr 2007 13:43:58 -0000 Received: (qmail 9670 invoked by uid 500); 8 Apr 2007 13:44:03 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 9584 invoked by uid 500); 8 Apr 2007 13:44:03 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 9573 invoked by uid 99); 8 Apr 2007 13:44:02 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Apr 2007 06:44:02 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Apr 2007 06:43:53 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8FFE071406C for ; Sun, 8 Apr 2007 06:43:33 -0700 (PDT) Message-ID: <436479.1176039813586.JavaMail.jira@brutus> Date: Sun, 8 Apr 2007 06:43:33 -0700 (PDT) From: "Daniel Fagerstrom (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Commented: (COCOON-2038) Implement true Object Oriented approach for handling super calls In-Reply-To: <3383788.1175695832231.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487442 ] Daniel Fagerstrom commented on COCOON-2038: ------------------------------------------- The explicit super call is because I didn't find any good way to call sitemaps in a "call through" way long time ago when I implemented the first version of the blocks fw. But of course it would be neater to not need to use an explicit super call. As the servlet service fw is supposed to work with any servlet the implicit super call mechanism need to use general servlet mechanisms. One way would be to call the base servlet and check for the status code of the http response object. If it is "200 OK" and possibly some other responses in the 2xx (and maybe 3xx) series, the response is just returned. If the response is "404 Not Found" (and maybe for some response codes in the 4xx and 5xx series) the super servlet is called. Otherwise the error response code is just returned. The mechanism should probably be implemented somewhere in the ServletServiceContext as most of the rest of the OO stuff is implemented there. > Implement true Object Oriented approach for handling super calls > ---------------------------------------------------------------- > > Key: COCOON-2038 > URL: https://issues.apache.org/jira/browse/COCOON-2038 > Project: Cocoon > Issue Type: Task > Components: - Servlet service framework > Reporter: Grzegorz Kossakowski > Fix For: 2.2-dev (Current SVN) > > > As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317 implementation of super calls should be changed to make it more OO-like. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.