cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Poetz <reinh...@apache.org>
Subject Re: environment.setStatus() in AbstractProcessingPipeline
Date Thu, 19 Apr 2007 14:17:44 GMT
Grzegorz Kossakowski wrote:
> Reinhard Poetz napisał(a):
>> Grek, what was your intention with this change? Since the status-code 
>> property stops working, I reverted your change.
> 
> My intention was to have http status code set in every case. Before this
> change, if serializer (or other component) did not set status code it was
> undefined after pipeline processing ended. That broke caching of servlet:
> source in the end. Now, with your change it also can be that status code will
> be undefined if serializer node is not given any status code, right?
> 
> The best way would be to set the code at the end of processing only if it was
> not set earlier down the processing. I have no idea how to do it, though :(

AFAICS, this information is not available

> In short: reverting my change will break caching of servlet: source in some
> cases.

currently, the status code is set in the SerializeNode class and has the default 
value of -1. Changing this to 200 would be easy but I have a gut feeling that 
this would be wrong ...

-- 
Reinhard Pötz           Independent Consultant, Trainer & (IT)-Coach

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------

Mime
View raw message