cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Poetz <reinh...@apache.org>
Subject environment.setStatus() in AbstractProcessingPipeline
Date Thu, 19 Apr 2007 13:37:17 GMT

Grek, what was your intention with this change? Since the status-code property 
stops working, I reverted your change.

reinhard@apache.org wrote:
> Author: reinhard
> Date: Thu Apr 19 06:28:04 2007
> New Revision: 530409
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=530409
> Log:
> we can't set the response status here as it overrides the status-code value which was
set by the serializer
> 
> Modified:
>     cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/components/pipeline/AbstractProcessingPipeline.java
> 
> Modified: cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/components/pipeline/AbstractProcessingPipeline.java
> URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/components/pipeline/AbstractProcessingPipeline.java?view=diff&rev=530409&r1=530408&r2=530409
> ==============================================================================
> --- cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/components/pipeline/AbstractProcessingPipeline.java
(original)
> +++ cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/components/pipeline/AbstractProcessingPipeline.java
Thu Apr 19 06:28:04 2007
> @@ -24,8 +24,6 @@
>  import java.util.NoSuchElementException;
>  import java.util.StringTokenizer;
>  
> -import javax.servlet.http.HttpServletResponse;
> -
>  import org.apache.avalon.excalibur.pool.Recyclable;
>  import org.apache.avalon.framework.logger.AbstractLogEnabled;
>  import org.apache.avalon.framework.parameters.ParameterException;
> @@ -548,8 +546,6 @@
>              handleException(e);
>          }
>  
> -        //Request has been succesfully processed, set approporiate status code
> -        environment.setStatus(HttpServletResponse.SC_OK);
>          return true;
>      }
>  
> @@ -661,8 +657,6 @@
>              handleException(e);
>          }
>          
> -        //Request has been succesfully processed, set approporiate status code
> -        environment.setStatus(HttpServletResponse.SC_OK);
>          return true;
>      }

-- 
Reinhard Pötz           Independent Consultant, Trainer & (IT)-Coach 

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------

Mime
View raw message