Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (herse.apache.org: domain of joerg.heinicke@gmx.de
 designates 213.165.64.20 as permitted sender)
Message-ID: <460DB2CB.4020208@gmx.de>
Date: Sat, 31 Mar 2007 03:00:59 +0200
From: Joerg Heinicke <joerg.heinicke@gmx.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: web3 block - lifecycle issues and class design
References: <BAY103-F14536C4BAF33626C6CC5BAD2630@phx.gbl>
In-Reply-To: <BAY103-F14536C4BAF33626C6CC5BAD2630@phx.gbl>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit

On 30.03.2007 20:36, Igor Naumov wrote:
> I have been using the block web3 for some time and ran into a couple of 
> issues.

Oh, somebody is using it :)

> Most of them are related to the lifecycle of the class - it seems that 
> some things are preventing a clean instantiation/disposal of the block 
> classes.
> 
> In particular, method Web3DataSourceSelectorImpl.dispose() destroys 
> (through =null ) the manager and lock properties.

Nulling the lock is indeed wrong, especially since dispose() is called 
for every instance (though we should have only one due to ThreadSafe). 
But I can't see why nulling the manager should cause any problem. It 
should be reinjected via service() on next access to the component.

> For some reason when an application (Cocoon) is restarted (without
> restarting servlet/J2EE/JVM, e.g. through a URL ?cocoon-reload=true),
> the class (Web3DataSourceSelectorImpl) is not completely unloaded,
> so the private static properties are not re-initialized.

I guess this only reloads the components but not their classes. Somebody 
else might confirm this.

Thanks for your report. Fixed it in SVN.

Regards
J�rg