Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 15926 invoked from network); 28 Mar 2007 23:38:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Mar 2007 23:38:12 -0000 Received: (qmail 4450 invoked by uid 500); 28 Mar 2007 23:38:19 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 4008 invoked by uid 500); 28 Mar 2007 23:38:18 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 3992 invoked by uid 99); 28 Mar 2007 23:38:18 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2007 16:38:18 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [68.230.240.8] (HELO eastrmmtao102.cox.net) (68.230.240.8) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2007 16:38:09 -0700 Received: from eastrmimpo02.cox.net ([68.1.16.120]) by eastrmmtao102.cox.net (InterMail vM.7.05.02.00 201-2174-114-20060621) with ESMTP id <20070328233747.DIVR24580.eastrmmtao102.cox.net@eastrmimpo02.cox.net> for ; Wed, 28 Mar 2007 19:37:47 -0400 Received: from [192.168.0.100] ([24.255.120.190]) by eastrmimpo02.cox.net with bizsmtp id gPdn1W00B46aSr40000000; Wed, 28 Mar 2007 19:37:47 -0400 Message-ID: <460AFC46.4020309@reverycodes.com> Date: Wed, 28 Mar 2007 19:37:42 -0400 From: Vadim Gritsenko User-Agent: Thunderbird 1.5.0.10 (Macintosh/20070221) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r522901 - in /cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main: java/org/apache/cocoon/caching/impl/CacheImpl.java resources/META-INF/cocoon/spring/cocoon-pipeline-impl-cache.xml References: <20070327132939.B88971A9838@eris.apache.org> <460AB0A1.3010503@reverycodes.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Torsten Curdt wrote: > > On 28.03.2007, at 20:14, Vadim Gritsenko wrote: > >> reinhard@apache.org wrote: >>> -public class CacheImpl >>> -extends AbstractLogEnabled >>> -implements Cache, ThreadSafe, Serviceable, Disposable, >>> Parameterizable { >>> +public class CacheImpl implements Cache { >>> + private Log logger = LogFactory.getLog(getClass()); >> >> Is there a reason why logger can not be static? > > http://wiki.apache.org/jakarta-commons/Logging/StaticLog So since Cocoon is not and should not be deployed in container's shared class loader, usage of 'static' is preferred. Vadim