cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: r523580 - /cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/caching/impl/CacheImpl.java
Date Thu, 29 Mar 2007 12:42:59 GMT
Felix Knecht wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Vadim Gritsenko schrieb:
>> felixk@apache.org wrote:
>>> Make method getLogger() visible for extending
>>> -    private Log getLogger() { +    protected Log getLogger() {
>> Felix,
>>
>> As far as commons logging usage pattern goes, extending classes
>> should create own instances of the log, otherwise log will get
>> really confusing, with class name of one class and message from
>> another class.
> 
> I see. But in this case we also can avoid the private method
> 'getLogger()' and use the defined class logger directly without going
> the long way round getLogger() ?

I think reason getLogger() was added simply to avoid many small changes to the file.

Vadim

Mime
View raw message