cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: svn commit: r523580 - /cocoon/trunk/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/caching/impl/CacheImpl.java
Date Thu, 29 Mar 2007 12:27:11 GMT
Reinhard Poetz wrote:
> Vadim Gritsenko wrote:
>> felixk@apache.org wrote:
>>> Make method getLogger() visible for extending 
>>
>>> -    private Log getLogger() {
>>> +    protected Log getLogger() {
>>
>> Felix,
>>
>> As far as commons logging usage pattern goes, extending classes should 
>> create own instances of the log, otherwise log will get really 
>> confusing, with class name of one class and message from another class.
> 
> if the getClass() method is used, then extending classes should be safe. 
> It's only problematic when static logging is used, then you're right, 
> that you would log into the category of the parent object.

Yep, thanks for correction, I was still assuming static logger :)

Vadim

Mime
View raw message