cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Woonsan Ko (JIRA)" <>
Subject [jira] Updated: (COCOON-1998) CocoonPortlet needs to allow overriding servlet-path parameter with preferences.
Date Mon, 05 Feb 2007 01:44:05 GMT


Woonsan Ko updated COCOON-1998:

    Attachment: servlet-path-pref-diff3.txt

I'm sorry and thank you, Carsten. 
I modified it not to hide instance variable. Also I reviewed and tested again. It works fine
when I tested on my production server.

To excuse myself, the local variable, 'servletPath' was added in Aug. 12, 2004, so I did not
modify the local variable hiding the instance variable.
Anyway, I think you are right. The local variable hiding the instance member is so confusing.

> CocoonPortlet needs to allow overriding servlet-path parameter with preferences.
> --------------------------------------------------------------------------------
>                 Key: COCOON-1998
>                 URL:
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: Blocks: Portal
>    Affects Versions: 2.1.11-dev (Current SVN)
>            Reporter: Woonsan Ko
>         Assigned To: Carsten Ziegeler
>             Fix For: 2.1.11-dev (Current SVN)
>         Attachments: servlet-path-pref-diff.txt, servlet-path-pref-diff2.txt, servlet-path-pref-diff3.txt
> The CocoonPortlet in BRANCH_2_1_X does not allow overriding the *servlet-path* init parameter
by preferences.
> If the CocoonPortlet reads preferences to override the 'servlet-path', portal users can
use manycoplet fragments without tedious portlet tag additions.
> FYI, some portals such as Jetspeed 2 allows inline preference settings, not allowed for
> Without this feature, portal users have to add portlet tags in the portlet.xml whenever
they need to use another coplet in the portal site.
> To test properly for the patch, you should add init-parameter in the cocoon/WEB-INF/portlet.xml
like the
> following:
>   <portlet>
>     <portlet-name>CocoonPortlet</portlet-name>
>     ...
>     <init-param>
>       <name>allow-preferences</name>
>       <value>true</value>
>     </init-param>
>     ...
>   </portlet>
> ManagedCocoonPortlet will read preferences just when the above parameter is set to true.
(I borrowed this from GenericServletPortlet in Apache portal bridges.)
> I've tested this modification under Jetspeed-2 (/WEB-INF/pages/default-page.psml).
> The portlet fragment can be added with preferences like the following:
>         <fragment id="dp-19" type="portlet" name="cocoon::CocoonPortlet">
>             <property name="row" value="6"/>
>             <property name="column" value="0"/>
>             <preference name="servlet-path" readOnly="true">
>                 <value>samples/blocks/portal/portlets/helloworld</value>
>             </preference>
>         </fragment>

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message