Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <15093804.1168421127828.JavaMail.jira@brutus>
Date: Wed, 10 Jan 2007 01:25:27 -0800 (PST)
From: "Carsten Ziegeler (JIRA)" <jira@apache.org>
To: dev@cocoon.apache.org
Subject: [jira] Closed: (COCOON-1979) [PATCH] Flow 2.1.0 reload-script =
 true does not reload scripts loaded via cocoon.load
In-Reply-To: <15889548.1168338507709.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/COCOON-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed COCOON-1979.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2-dev (Current SVN)
                   2.1.11-dev (Current SVN)

Oh, yes - you're right of course.
Your patch is applied - please cross check

> [PATCH] Flow 2.1.0 reload-script = true does not reload scripts loaded via cocoon.load
> --------------------------------------------------------------------------------------
>
>                 Key: COCOON-1979
>                 URL: https://issues.apache.org/jira/browse/COCOON-1979
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10
>            Reporter: Rob Berens
>         Assigned To: Carsten Ziegeler
>             Fix For: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
>
>         Attachments: patch-1.txt, patch-2.txt
>
>
> When a script is loaded via cocoon.load the refresh parameter for CompilingInterpreter.ScripSourceEntry.getScript is always set to false. In 2.1.8 this parameter was incorrectly ignored, when checking the compile time against the last modified time in CompilingInterpreter.ScripSourceEntry.getScript. This was corrected in 2.19 or 2.1.10. The side effect however is that scripts loaded via cocoon.load are never checked for modification, as FOM_JavaScriptInterpreter.compileScript(Context, String) always calls the getScript method with refresh = false.
> In the supplied patched (patch-1.txt and patch-2.txt) the compileScript method now sets the refresh indicator dependent on the reload-script and check-time parameters. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira