cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <>
Subject [jira] Commented: (COCOON-1979) [PATCH] Flow 2.1.0 reload-script = true does not reload scripts loaded via cocoon.load
Date Wed, 10 Jan 2007 08:18:29 GMT


Carsten Ziegeler commented on COCOON-1979:

Although your patch fixes the problem, I'm wondering why a 

                compiledScript = entry.getScript(cx, this.scope, reloadScripts, this);

doesn't do the job as well. The getScript method compares already the timestamps for reloading.

> [PATCH] Flow 2.1.0 reload-script = true does not reload scripts loaded via cocoon.load
> --------------------------------------------------------------------------------------
>                 Key: COCOON-1979
>                 URL:
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10, 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
>            Reporter: Rob Berens
>         Assigned To: Carsten Ziegeler
>         Attachments: patch-1.txt, patch-2.txt
> When a script is loaded via cocoon.load the refresh parameter for CompilingInterpreter.ScripSourceEntry.getScript
is always set to false. In 2.1.8 this parameter was incorrectly ignored, when checking the
compile time against the last modified time in CompilingInterpreter.ScripSourceEntry.getScript.
This was corrected in 2.19 or 2.1.10. The side effect however is that scripts loaded via cocoon.load
are never checked for modification, as FOM_JavaScriptInterpreter.compileScript(Context, String)
always calls the getScript method with refresh = false.
> In the supplied patched (patch-1.txt and patch-2.txt) the compileScript method now sets
the refresh indicator dependent on the reload-script and check-time parameters. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message