Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 67885 invoked from network); 7 Dec 2006 22:48:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Dec 2006 22:48:45 -0000 Received: (qmail 18484 invoked by uid 500); 7 Dec 2006 22:48:48 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 18371 invoked by uid 500); 7 Dec 2006 22:48:47 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 18275 invoked by uid 99); 7 Dec 2006 22:48:47 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from [195.186.19.63] (HELO mail16.bluewin.ch) (195.186.19.63) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Dec 2006 14:48:44 -0800 Received: from [192.168.0.102] (83.76.134.217) by mail16.bluewin.ch (Bluewin 7.3.118) id 4513C8520123B9CE for dev@cocoon.apache.org; Thu, 7 Dec 2006 22:41:41 +0000 Subject: Re: [2.1.10] WildcardHelperTestCase fails From: Alfred Nathaniel Reply-To: a.nathaniel@bluewin.ch To: dev@cocoon.apache.org In-Reply-To: <45767293.3020701@apache.org> References: <457543B8.3010303@apache.org> <1165357686.5783.7.camel@localhost> <45767293.3020701@apache.org> Content-Type: text/plain Date: Thu, 07 Dec 2006 23:41:40 +0100 Message-Id: <1165531300.5700.11.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On Wed, 2006-12-06 at 08:34 +0100, Carsten Ziegeler wrote: > Ok, I removed the usage of the deprecated matching code and replaced it > with using the new matcher. In addition I removed the duplicate test > case for the WildcardHelper class and commented out the failing test > in the remaining test case. Thanks Carsten, WildcardHelper is now no longer used in 2.1. Should we remove it together with WildcardHelperTestCase? That breaks private Cocoon components which may still use it but IMHO that is better than just giving a depracation warning. ("Friends don't let friends use broken WildcardHelper.") WildcardMatcherHelper is not a drop-in replacement of WildcardHelper but easy enough to use. WDYT? Cheers, Alfred.