cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: [2.1.10] WildcardHelperTestCase fails
Date Fri, 08 Dec 2006 07:13:57 GMT
Alfred Nathaniel wrote:
> On Wed, 2006-12-06 at 08:34 +0100, Carsten Ziegeler wrote:
> 
>> Ok, I removed the usage of the deprecated matching code and replaced it
>> with using the new matcher. In addition I removed the duplicate test
>> case for the WildcardHelper class and commented out the failing test
>> in the remaining test case.
> 
> Thanks Carsten,
> 
> WildcardHelper is now no longer used in 2.1.  Should we remove it
> together with WildcardHelperTestCase?
> 
> That breaks private Cocoon components which may still use it but IMHO
> that is better than just giving a depracation warning.  ("Friends don't
> let friends use broken WildcardHelper.")
> 
> WildcardMatcherHelper is not a drop-in replacement of WildcardHelper but
> easy enough to use.
> 
> WDYT?
> 
Hmm, yes, this seems logical - on the other hand there might be people
relying on the bugs in the code :)

I think you should start a vote on this and hopefully we get the buggy
code out of 2.1.10.

Carsten

-- 
Carsten Ziegeler - Chief Architect
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/

Mime
View raw message