Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 4204 invoked from network); 7 Nov 2006 19:28:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Nov 2006 19:28:47 -0000 Received: (qmail 92386 invoked by uid 500); 7 Nov 2006 19:28:56 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 92316 invoked by uid 500); 7 Nov 2006 19:28:56 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 92305 invoked by uid 99); 7 Nov 2006 19:28:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2006 11:28:56 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [87.106.15.5] (HELO mail.mindquarry.com) (87.106.15.5) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2006 11:28:41 -0800 Received: from [192.168.0.15] (dslb-088-072-242-071.pools.arcor-ip.net [88.72.242.71]) by mail.mindquarry.com (Postfix) with ESMTP id 754AF79C2D4 for ; Tue, 7 Nov 2006 19:28:19 +0000 (GMT) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <455050F5.70908@nada.kth.se> References: <454A837A.1090606@nada.kth.se> <455050F5.70908@nada.kth.se> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Lars Trieloff Subject: Re: Performance with blocks protocol Date: Tue, 7 Nov 2006 20:29:17 +0100 To: dev@cocoon.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org Hi, we should check that there are really no more than 32 instances of ResourceReader on the heap. If this is the case, all we need to do is to raise the -Xmx limit and add a note to the docs that blocks might need some more memory. Meanwhile I will try to reproduce this problem in the cocoon-blocks- fw-demo so that it can be tested using JMeter and YourKit Java Profiler. Lars Am 07.11.2006 um 10:25 schrieb Daniel Fagerstrom: > Alexander Klimetschek skrev: >> This seems to be the real problem. There are new ResourceReader >> instances for each request (along with the BlockSource, >> BlockConnection etc. connected with it), but they are never >> reused. Instead they keep in memory, referenced by some >> ThreadLocal storage. >> >> Something in the special handling o.a.c.sitemap.SitemapServlet >> might be buggy, but we cannot see what. Do you have time to >> further look at that this week? When using forms, the amount of >> data that is collected this way increases so fast, that we >> sometimes get an OutOfMemory after 3-4 reloads... > > Looking at the ResourceReader it is Recyclable and has a default > max-pool-size of 32. I don't know enough about the Avalon life > style implementation to know exactly what happens. As long as there > are no more than 32 instances of ResourceReaders they are, AFAIU > supposed to be kept in a pool in the memory. But we would get a > problem if the recycle method of the ResourceReader is called to > late or not at all in that case the other object would be kept in > memory when they should have been garbage collected. -- Lars Trieloff visit http://www.mindquarry.com/