Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 86950 invoked from network); 7 Nov 2006 09:46:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Nov 2006 09:46:09 -0000 Received: (qmail 51788 invoked by uid 500); 7 Nov 2006 09:46:18 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 51710 invoked by uid 500); 7 Nov 2006 09:46:18 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 51699 invoked by uid 99); 7 Nov 2006 09:46:18 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2006 01:46:18 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [212.85.125.162] (HELO v07528.home.net.pl) (212.85.125.162) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 07 Nov 2006 01:45:50 -0800 Received: from sj163.internetdsl.tpnet.pl (HELO ?192.168.1.62?) (lgawron.mobilebox@home@80.55.87.163) by m029.home.net.pl with SMTP; Tue, 7 Nov 2006 09:45:07 -0000 Message-ID: <455055A6.8080101@mobilebox.pl> Date: Tue, 07 Nov 2006 10:45:10 +0100 From: Leszek Gawron User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: Restructuring directory structure[was [Vote] Block artifact directory structure] References: <45470272.1030905@apache.org> <4549ABBE.2000601@apache.org> <454BB06A.5040400@apache.org> <454BC985.30705@apache.org> <454BCBDB.8000807@apache.org> <454C8223.2040301@mobilebox.pl> <454C918F.8070504@apache.org> <454C9738.1070801@mobilebox.pl> <454CA68F.2050505@apache.org> <454CB2F5.6060107@mobilebox.pl> <454CC197.8080701@apache.org> <454F05F7.2070003@otego.com> <454F07DE.3020906@mobilebox.pl> <454F0E5A.1050701@mobilebox.pl> <454F3985.7030207@otego.com> <454F436B.6040808@mobilebox.pl> <454F4965.5060405@apache.org> <454F4B5D.2080706@apache.org> <454F4BF5.60309@mobilebox.pl> <454F4D9D.1060808@apache.org> <454F939E.1010403@apache.org> <454F9716.5030606@mobilebox.pl> <454F9BCE.7010805@apache.org> <455034FB.3010005@apache.org> In-Reply-To: <455034FB.3010005@apache.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Carsten Ziegeler wrote: > Giacomo Pati wrote: >>>> 1. IMO cocoon components should either use Settings.getRunningMode() to >>>> get the current running mode or have the mode injected. Allowing >>>> components to determine the running mode using any algorithm (even the >>>> easiest one) leads to inconsistencies. >> I do absolutely agree with you. > Exactly. > >>>> 2. Some components (like CocoonOverridePropertyConfigurer, which has >>>> already been fixed) use the Settings object but happily fallback to >>>> default mode when settings object is not available. The result of such >>>> situation is that a bean that has been incorrectly dependence injected >>>> uses other running mode than you might think. Beans using running mode. >>>> should simply throw if they cannot determine one. >> As Carsten pointed out in a recent mail, we do not have the "original >> working code" yet in the repo (dunno where it has been gone, nor which >> ever class he had in mind as "original working code"). Maybe we should >> just restore it and see whether that fix our problems > Yes, let's please restore the old code in the settings element parser; I > think that's all we need. which is? -- Leszek Gawron CTO at MobileBox Ltd.