cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: svn commit: r478517 - /cocoon/trunk/blocks/cocoon-fop/pom.xml
Date Fri, 24 Nov 2006 15:47:49 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Leszek Gawron wrote:
> Giacomo Pati wrote:
>>
>> lgawron@apache.org wrote:
>>> Author: lgawron
>>> Date: Thu Nov 23 01:08:16 2006
>>> New Revision: 478517
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=478517
>>> Log:
>>> invalid build order
>>> Modified:
>>>     cocoon/trunk/blocks/cocoon-fop/pom.xml
>>> Modified: cocoon/trunk/blocks/cocoon-fop/pom.xml
>>> URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-fop/pom.xml?view=diff&rev=478517&r1=478516&r2=478517
>>> ==============================================================================
>>> --- cocoon/trunk/blocks/cocoon-fop/pom.xml (original)
>>> +++ cocoon/trunk/blocks/cocoon-fop/pom.xml Thu Nov 23 01:08:16 2006
>>> @@ -35,8 +35,8 @@
>>>    <name>FOP Block [modules]</name>
>>>    <description/>
>>>    <modules>
>>> -    <module>cocoon-fop-sample</module>
>>>      <module>cocoon-fop-impl</module>
>>> +    <module>cocoon-fop-sample</module>
>>>      <module>cocoon-fop-ng-sample</module>
>>>      <module>cocoon-fop-ng-impl</module>
>>>    </modules>
>> Is this really important? Shouldn't Maven build the order from the
>> dependencies a module has?
> 
> Yes it is. The modules are built in the order provided. So in the case I
> corrected cocoon-fop-sample will get built using old version of
> cocoon-fop-impl (from your local repository). If you have no such
> artifact in repository alread and error raises.
> 
>> Doesn't the cocoon-fop-sample module define a dependency on the
>> cocoon-fop-impl module?
> 
> If you use maven embedder (for example by using m2eclipse plugin) you
> will notice that previous configuration will cause cocoon-fop-impl.jar
> put on the classpath along with cocoon-fop-impl/src/main/java|resources
> folder.
> 
> I've run through this kind of problems several months ago in my private
> project. Maybe current maven version is handles module building order
> automatically regardles of the actual order in xml file (I doubt it).

I do have a medium sized project at hand where the root pom defines the
modules in strict alphabetic order but a build of the hole project shows
me that the order is not as such. Instead Maven rearranges the build
order according to the deps in the respective modules. So if the deps
are correct Maven will build correct (that's my verified assumption) and
the sequence of the module definition doesn't play any role.

Ciao

- --
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFZxQkLNdJvZjjVZARAqa8AJ4mGgVSUHoAU/soQhtJ89Ogwy8ezQCg2/hn
YDf75W8oFJb516MXFj6CZxU=
=zwYn
-----END PGP SIGNATURE-----

Mime
View raw message