cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: Restructuring directory structure[was [Vote] Block artifact directory structure]
Date Tue, 07 Nov 2006 08:52:51 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Carsten Ziegeler wrote:
> Giacomo Pati wrote:
>>>> 1. IMO cocoon components should either use Settings.getRunningMode() to
>>>> get the current running mode or have the mode injected. Allowing
>>>> components to determine the running mode using any algorithm (even the
>>>> easiest one) leads to inconsistencies.
>> I do absolutely agree with you.
> Exactly.
> 
>>>> 2. Some components (like CocoonOverridePropertyConfigurer, which has
>>>> already been fixed) use the Settings object but happily fallback to
>>>> default mode when settings object is not available. The result of such
>>>> situation is that a bean that has been incorrectly dependence injected
>>>> uses other running mode than you might think. Beans using running mode.
>>>> should simply throw if they cannot determine one.
>> As Carsten pointed out in a recent mail, we do not have the "original
>> working code" yet in the repo (dunno where it has been gone, nor which
>> ever class he had in mind as "original working code"). Maybe we should
>> just restore it and see whether that fix our problems
> Yes, let's please restore the old code in the settings element parser; I
> think that's all we need.

Well, actually I'm lost wrt what the "original code" was. I've diffed some
of the latest revisions but couldn't figure out what could have been the
"original code". Can someone help me out (Carsten, Leszek) as I'm rather
near to have it going again (wrt jetty6:run in a block).

> 
>>>> I am probably picky about this but hey - you're the ones I've learnt my
>>>> values from :)
> Carsten

- --
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFUEliLNdJvZjjVZARAvOxAJ4xYjW0O0r0XmEb0sxguJuc8+ZalQCfXowR
TBM2dVILYEDp0MWa+hsx7nQ=
=CkyU
-----END PGP SIGNATURE-----

Mime
View raw message