cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leszek Gawron <lgaw...@mobilebox.pl>
Subject Re: Restructuring directory structure[was [Vote] Block artifact directory structure]
Date Mon, 06 Nov 2006 14:48:49 GMT
Giacomo Pati wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> 
> Leszek Gawron wrote:
>> Felix Knecht wrote:
>>> +        final String runningMode =
>>> getSystemProperty(Settings.PROPERTY_RUNNING_MODE,
>>> this.getAttributeValue(element, RUNNING_MODE_ATTR, null) );
>> 1. the logic for obtaining running mode is scattered again
> 
> You seem to have a problem with that :-)
> 
> No, seriously. It seems a little over engineered at first as I cannot
> imagine anyone willing to have its own implementation of a
> getSystemProperty method (beacause they are protected). On the other
> hand (if we make those method private) I find the solution from Felix
> quite simple.

If everyone is OK with that I will have no objections either :).

> 
>> 2. system property takes preference over the setting in cocoon.xconf. Is
>> that correct?
> 
> Yes, I think the System property should take precedence over the setting
> in cocoon.xconf

Whatever you like. I won't be using <cocoon:settings runningMode="sth"/> 
anyway

-- 
Leszek Gawron                                    CTO at MobileBox Ltd.


Mime
View raw message