cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: Restructuring directory structure[was [Vote] Block artifact directory structure]
Date Mon, 06 Nov 2006 14:40:37 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Leszek Gawron wrote:
> Felix Knecht wrote:
>> +        final String runningMode =
>> getSystemProperty(Settings.PROPERTY_RUNNING_MODE,
>> this.getAttributeValue(element, RUNNING_MODE_ATTR, null) );
> 
> 1. the logic for obtaining running mode is scattered again

You seem to have a problem with that :-)

No, seriously. It seems a little over engineered at first as I cannot
imagine anyone willing to have its own implementation of a
getSystemProperty method (beacause they are protected). On the other
hand (if we make those method private) I find the solution from Felix
quite simple.

> 2. system property takes preference over the setting in cocoon.xconf. Is
> that correct?

Yes, I think the System property should take precedence over the setting
in cocoon.xconf

- --
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFT0lkLNdJvZjjVZARAm3/AJ9FigCA2PcpMl35cvw0Bm66kF3HuwCgkqh+
t6ZfBCpfqaWZ/IS32tpyaV4=
=biBj
-----END PGP SIGNATURE-----

Mime
View raw message