Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <9968889.1160768856073.JavaMail.jira@brutus>
Date: Fri, 13 Oct 2006 12:47:36 -0700 (PDT)
From: "Carsten Ziegeler (JIRA)" <jira@apache.org>
To: dev@cocoon.apache.org
Subject: [jira] Commented: (COCOON-1933) [Patch] Automatic loading of flow
 scripts in "flow/" must not load directories
In-Reply-To: <2488336.1160659054939.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/COCOON-1933?page=comments#action_12442085 ] 
            
Carsten Ziegeler commented on COCOON-1933:
------------------------------------------

I think this wouldn't help us in this case as even the Excalibur source resolver can't tell if a resource is a directory or a file in the case of an unexpanded war.
I checked in a fix yesterday which should solve most of the problems when running unexpanded, but the file/directory detection is still an issue. I guess we could use getFile() first and if that fails use getInputStream() for testing?

> [Patch] Automatic loading of flow scripts in "flow/" must not load directories
> ------------------------------------------------------------------------------
>
>                 Key: COCOON-1933
>                 URL: http://issues.apache.org/jira/browse/COCOON-1933
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Alexander Klimetschek
>         Attachments: cocoon-flow-only-files.patch
>
>
> The automatic loading of everything inside flow/ also tries to load directories, which cannot be compiled like files. Happens typically when you have a subversion directory (.svn) or other version-control directory inside.
> The stacktrace for the problem:
> Caused by: org.apache.excalibur.source.SourceNotFoundException: file:/Users/alex/Mindquarry/hack/mindquarry-teamspace-web/mindquarry-teamspace-block/src/main/resources/COB-INF/flow/.svn/ doesn't exist.
>     at org.apache.excalibur.source.impl.FileSource.getInputStream(FileSource.java:150)
>     at org.apache.cocoon.components.flow.javascript.fom.FOM_JavaScriptInterpreter.compileScript(FOM_JavaScriptInterpreter.java:502)
>     at org.apache.cocoon.components.flow.CompilingInterpreter$ScriptSourceEntry.getScript(CompilingInterpreter.java:112)
>     at org.apache.cocoon.components.flow.javascript.fom.FOM_JavaScriptInterpreter.setupContext(FOM_JavaScriptInterpreter.java:453)
>     at org.apache.cocoon.components.flow.javascript.fom.FOM_JavaScriptInterpreter.callFunction(FOM_JavaScriptInterpreter.java:572)
>     at org.apache.cocoon.components.treeprocessor.sitemap.CallFunctionNode.invoke(CallFunctionNode.java:109)
>     ... 43 more
> Caused by: java.io.FileNotFoundException: /Users/alex/Mindquarry/hack/mindquarry-teamspace-web/mindquarry-teamspace-block/src/main/resources/COB-INF/flow/.svn (No such file or directory)
>     at java.io.FileInputStream.open(Native Method)
>     at java.io.FileInputStream.<init>(FileInputStream.java:106)
>     at org.apache.excalibur.source.impl.FileSource.getInputStream(FileSource.java:146)
>     ... 48 more 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira