cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lars Trieloff <>
Subject Uploads not working with blocks, proposal for fix
Date Fri, 27 Oct 2006 12:10:51 GMT
Hi Daniel,

I've just noted that uploads with CForms are not working with the  
Blocks Framework. The reason is a bug in  
org.apache.cocoon.environment.http.HttpRequest.get() that checks for  
a wrapped MultipartHttpServletRequest. With the Blocks framework the  
actual MultipartHttpServletRequest is wrapped into an anonymous  
HttpServletRequestWrapper in DispatcherServlet.

My proposal to fix the bug without including cyclic dependencies is  
to create a new abstract class  
org.apache.cocoon.AbstractValueHttpServletRequestWrapper that  
includes a get-method, extends HttpRequestWraper and will be extended  
by MultipartHttpServletRequestWrapper as well as by the anonymous  
class in DispatcherServlet. The HttpRequest would check for this  
class and uploads are working again.

What do you think?

Lars Trieloff

View raw message