cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Gianni (JIRA)" <j...@apache.org>
Subject [jira] Created: (COCOON-1945) Mounting the same subsitemap multiple time, but with different prefixes, causes an error
Date Mon, 30 Oct 2006 18:12:17 GMT
Mounting the same subsitemap multiple time, but with different prefixes, causes an error
----------------------------------------------------------------------------------------

                 Key: COCOON-1945
                 URL: http://issues.apache.org/jira/browse/COCOON-1945
             Project: Cocoon
          Issue Type: Bug
          Components: * Cocoon Core
    Affects Versions: 2.2-dev (Current SVN)
            Reporter: Simone Gianni


Suppose I have a subsitemap that generates XML documents, and then i want to mount it with
different prefixes. For example :

<map:match pattern="*/doc/**">
  <map:action ......>
  <map:mount src="mysubfolder" location="{1}"/>
</map:match>

<map:match pattern="something/*/**">
  <map:generate src="cocoon://{1}/doc/{2}"/>
  <map:transform src="cocoon://otherprefix/doc/somethingelse"/>
  ....

The second call with cocoon:// fails with the cause that "/otherprefix/docs/blabla does not
start with /originalprefix/".

This is because in MountNode getProcessor() the TreeProcessors are cached based on their source
(mysubfolder/sitemap.xmap), but not regarding their prefix.

I "solved" this using also the prefix in the cache key :

Index: src/main/java/org/apache/cocoon/components/treeprocessor/sitemap/MountNode.java
===================================================================
--- src/main/java/org/apache/cocoon/components/treeprocessor/sitemap/MountNode.java     (revision
449416)
+++ src/main/java/org/apache/cocoon/components/treeprocessor/sitemap/MountNode.java     (working
copy)
@@ -135,13 +135,13 @@
     private synchronized TreeProcessor getProcessor(String source, String prefix)
     throws Exception {

-        TreeProcessor processor = (TreeProcessor) processors.get(source);
+        TreeProcessor processor = (TreeProcessor) processors.get(source + "||" + prefix);
         if (processor == null) {

             processor = this.parentProcessor.createChildProcessor(source, this.checkReload,
prefix);

             // Associate to the original source
-            processors.put(source, processor);
+            processors.put(source + "||" + prefix, processor);
         }

         return processor;

But this means that two tree processors gets generated to represent the same sitemap, with
only the prefix changing. I'm sure that there is a best way to do it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message