Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <450E4BE7.40103@hippo.nl>
Date: Mon, 18 Sep 2006 09:33:59 +0200
From: Niels van Kampenhout <n.vankampenhout@hippo.nl>
Organization: Hippo
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: Caching jx *without* flow
References: <1158349311.17986.4.camel@localhost>
 <450D361D.1070407@mobilebox.pl>
In-Reply-To: <450D361D.1070407@mobilebox.pl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Leszek Gawron wrote:
> Thorsten Scherler wrote:
>> Hi all, hi Ard,
>>
>> http://marc.theaimsgroup.com/?l=xml-cocoon-users&m=115194685214066&w=2
>> "...
>>>> Now, the cached jx would depend on these three parameters. 
>>> Very easy to use, and less error prone than the flow part.
>>>> If somebody is interested in the code I will hear "
>>
>> Yes very interested.
>> http://svn.apache.org/viewvc?view=rev&rev=446701
>> https://issues.apache.org/jira/browse/FOR-931
>>
>> Can you attach a patch to this issue or commit it to cocoon directly?
>>
>> Would be awesome.
> Do I get it right:
> 
> you want to patch JXTG to automatically build up a cache key from cocoon 
> parameters?
> 
> <map:match pattern="foo">
>   <map:generate src="foobar.jx">
>     <map:parameter name="foo" value="bar"/>
>     <map:parameter name="bar" value="foo"/>
>   </map:generate>
>   <map:serialize/>
> </map:match>
> 
> so cocoon:/foo gets cached with something like "foo=bar&bar=foo"?
> 
> Why need a patch for that? After all you already have jx:cache-key and 
> jx:cache-validity.
> 

Since Ard is on holiday until the GetTogether, I'll try to answer this 
question.

The reason is, as Ard said, to make it less error prone. People easily 
make mistakes if they have to build a cachekey string themselves, en 
they also easily forget to actually put the jx:cache-key and 
jx:cache-validity attributes in the JX template. I am talking from 
experience!

It also makes the code more readable/transparent/explicit, because you 
don't need the extra flow step anymore in many cases.

Regards,
Niels