cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Trieloff (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-1898) [PATCH] XPatch support for maven-cocoon-deployer-plugin
Date Mon, 04 Sep 2006 11:45:25 GMT
    [ http://issues.apache.org/jira/browse/COCOON-1898?page=comments#action_12432499 ] 
            
Lars Trieloff commented on COCOON-1898:
---------------------------------------

Leszek,

there are some weak points in the XUpdate language, for example the if-semantics are not yet
defined.

Putting the patches below src/main/xpath is no problem when you add this path to the list
of paths that are considered by the jar plugin (or whatever does the packaging)

I understand your motivation for multiple patches targeting one file.

For the long command line: could not the cocoon-deployer call cocoon:xupdate before finishing
the deployment? The deployer scans the required jar files for patches, extracts them to a
target/xpatch directory, calls cocoon:xupdate which then uses patches in target/xpatch and
/src/main/xpatch to patch the extracted files.

> [PATCH] XPatch support for maven-cocoon-deployer-plugin
> -------------------------------------------------------
>
>                 Key: COCOON-1898
>                 URL: http://issues.apache.org/jira/browse/COCOON-1898
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: - Build System: Maven
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Lars Trieloff
>         Attachments: maven-cocoon-deployer-plugin-with-xpatch-support.patch
>
>
> The cocoon-deployer-plugin has currently no support for XPatch, which makes it difficult
to modify the web.xml when developing cocoon blocks. For example the cocoon-xmldb-impl block
should add, when deployed, a servlet for xindice and a servlet mapping for the xindice servlet.
This was possible in 2.1 using the XConfToolTask, but is no longer possible with the current
state of the deployer-plugin.
> My patch adds support for patching the web.xml file using *.xweb files in the /conf directory
of a block by filtering the block's jar file during deployment for conf/*.xweb files, caching
the patch document temporarily and applying them (using code from the orgiginal XConfToolTask
in 2.1) to the web.xml. The patch has currently no support for other files than conf/*.xweb
files and does not support any property expansion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message