Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 89966 invoked from network); 28 Aug 2006 15:35:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 28 Aug 2006 15:35:18 -0000 Received: (qmail 48944 invoked by uid 500); 28 Aug 2006 15:35:15 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 48886 invoked by uid 500); 28 Aug 2006 15:35:15 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 48875 invoked by uid 99); 28 Aug 2006 15:35:15 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2006 08:35:15 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [84.96.21.10] (HELO trinity.anyware-tech.com) (84.96.21.10) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2006 08:35:14 -0700 Received: from localhost (localhost [127.0.0.1]) by trinity.anyware-tech.com (Postfix) with ESMTP id A9C4D4005D2 for ; Mon, 28 Aug 2006 17:34:50 +0200 (CEST) Received: from trinity.anyware-tech.com ([127.0.0.1]) by localhost (trinity.anyware-tech.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 10268-02 for ; Mon, 28 Aug 2006 17:34:49 +0200 (CEST) Received: from vision.anyware (vision.anyware [10.0.1.12]) by trinity.anyware-tech.com (Postfix) with ESMTP id DB43D40013A for ; Mon, 28 Aug 2006 17:34:49 +0200 (CEST) Received: by vision.anyware (Postfix, from userid 1021) id 9EE746497; Mon, 28 Aug 2006 17:34:51 +0200 (CEST) Date: Mon, 28 Aug 2006 17:34:51 +0200 From: Jean-Baptiste Quenot To: dev@cocoon.apache.org Subject: Re: [jira] Created: (COCOON-1898) [PATCH] XPatch support for maven-cocoon-deployer-plugin Message-ID: <20060828153451.GH89053@vision.anyware> Mail-Followup-To: dev@cocoon.apache.org References: <2820129.1156402049415.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2820129.1156402049415.JavaMail.jira@brutus> User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Virus-Scanned: Debian amavisd-new at anyware-tech.com X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N * Lars Trieloff (JIRA): > The cocoon-deployer-plugin has currently no support for XPatch, > which makes it difficult to modify the web.xml when developing > cocoon blocks. For example the cocoon-xmldb-impl block should > add, when deployed, a servlet for xindice and a servlet mapping > for the xindice servlet. This was possible in 2.1 using the > XConfToolTask, but is no longer possible with the current state > of the deployer-plugin. > > My patch adds support for patching the web.xml file using *.xweb > files in the /conf directory of a block by filtering the block's > jar file during deployment for conf/*.xweb files, caching the > patch document temporarily and applying them (using code from > the orgiginal XConfToolTask in 2.1) to the web.xml. The patch > has currently no support for other files than conf/*.xweb files > and does not support any property expansion. Hey, that sounds good. Has anyone been able to review this contribution? -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/