cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leszek Gawron <lgaw...@mobilebox.pl>
Subject Re: svn commit: r429801 - in /cocoon/trunk/blocks/cocoon-xsp/cocoon-xsp-impl/src/main/java/org/apache/cocoon/xsp/handler: AbstractComponentHandler.java ComponentEnvironment.java
Date Tue, 08 Aug 2006 20:38:55 GMT
lgawron@apache.org wrote:
> Author: lgawron
> Date: Tue Aug  8 13:28:55 2006
> New Revision: 429801
> 
> URL: http://svn.apache.org/viewvc?rev=429801&view=rev
> Log:
> Hello
> This is my first Cocoon page!
> With the help of XSP and null 2.2.0-M2-SNAPSHOT ...

question 1: why is Constants.COMPLETE_NAME containing 'null 
2.2.0-M2-SNAPSHOT'?

> 
> Modified:
>     cocoon/trunk/blocks/cocoon-xsp/cocoon-xsp-impl/src/main/java/org/apache/cocoon/xsp/handler/AbstractComponentHandler.java
>     cocoon/trunk/blocks/cocoon-xsp/cocoon-xsp-impl/src/main/java/org/apache/cocoon/xsp/handler/ComponentEnvironment.java
> 
> Modified: cocoon/trunk/blocks/cocoon-xsp/cocoon-xsp-impl/src/main/java/org/apache/cocoon/xsp/handler/AbstractComponentHandler.java
> URL: http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-xsp/cocoon-xsp-impl/src/main/java/org/apache/cocoon/xsp/handler/AbstractComponentHandler.java?rev=429801&r1=429800&r2=429801&view=diff
> ==============================================================================
> --- cocoon/trunk/blocks/cocoon-xsp/cocoon-xsp-impl/src/main/java/org/apache/cocoon/xsp/handler/AbstractComponentHandler.java
(original)
> +++ cocoon/trunk/blocks/cocoon-xsp/cocoon-xsp-impl/src/main/java/org/apache/cocoon/xsp/handler/AbstractComponentHandler.java
Tue Aug  8 13:28:55 2006
> @@ -258,7 +258,7 @@
>       * TODO - perhaps we can remove this later?
>       */
>      public static ComponentHandler getComponentHandler(Class clazz, Logger logger, Context
context, ServiceManager manager, Configuration config) throws Exception {
> -        ComponentEnvironment env = new ComponentEnvironment(logger, context, manager);
> +        ComponentEnvironment env = new ComponentEnvironment(logger, context, manager,
clazz.getClassLoader());

Question 2: Is it OK to fix ClassNotFoundException for xsp generated 
classes like this?

The xsp classes are first loaded with ClassLoadManagerImpl. Then the 
name of the class is passed to AbstractComponentHandler which tries to 
load it with cocoon's classloader which knows nothing about xsp 
generated classes.

Apart from 'null 2.2.0-M2-SNAPSHOT' and python samples all other XSP 
samples work properly. I think we could make a release.

-- 
Leszek Gawron                                      lgawron@mobilebox.pl
IT Manager                                         MobileBox sp. z o.o.
+48 (61) 855 06 67                              http://www.mobilebox.pl
mobile: +48 (501) 720 812                       fax: +48 (61) 853 29 65

Mime
View raw message