cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Quenot <...@apache.org>
Subject Re: cforms incompatibility in 2.1.9 (was [Fwd: [jira] Reopened: (COCOON-1687) [PATCH] JXPATHBinding : when saving the form, remove xml elements if the value of the widget is null])
Date Wed, 09 Aug 2006 09:17:54 GMT
* Antonio Gallardo:
> Jean-Baptiste Quenot escribió:
> >Namely <fb:repeater> and <fb:multi-value> are known to be broken
> >in some cases.
> >  
> Would you provide a test case in order to fix it and avoid a regression in the future?
:-)

Not a testcase, but some facts.

------------------------------------------------------------------------
About <fb:multi-value>:

http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/MultiValueJXPathBinding.java?view=markup

Look at the TODO in the code.  You will see that the XPath
expression gets appended the row positions.

Example if the row-path is "entry":

entry[1]
entry[2]
entry[3]
...

Then what about a row-path "entry/@value":

entry/@value[1]
entry/@value[2]
entry/@value[3]
...

It doesn't make sense so basically the whole code is broken.

------------------------------------------------------------------------
About <fb:repeater>:

There is a user experience related here, but I know many users
that avoid <fb:repeater> like the plague:
http://marc2.theaimsgroup.com/?l=xml-cocoon-users&m=111757381624547&w=2

Basically you need to use <fb:simple-repeater> instead, without
support for <fb:identity> however, useless anyway when binding to
XML IMO.
-- 
     Jean-Baptiste Quenot
aka  John Banana Qwerty
http://caraldi.com/jbq/

Mime
View raw message