Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 58471 invoked from network); 10 Jul 2006 07:40:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Jul 2006 07:40:18 -0000 Received: (qmail 34059 invoked by uid 500); 10 Jul 2006 07:40:17 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 33570 invoked by uid 500); 10 Jul 2006 07:40:15 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 33559 invoked by uid 99); 10 Jul 2006 07:40:15 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jul 2006 00:40:15 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of ralph.goers@dslextreme.com designates 66.51.199.81 as permitted sender) Received: from [66.51.199.81] (HELO mail5.dslextreme.com) (66.51.199.81) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 10 Jul 2006 00:40:15 -0700 Received: (qmail 12435 invoked from network); 10 Jul 2006 07:39:54 -0000 Received: from unknown (HELO [127.0.0.1]) (66.51.196.164) by mail5.dslextreme.com with SMTP; Mon, 10 Jul 2006 00:39:54 -0700 Message-ID: <44B20452.3080608@dslextreme.com> Date: Mon, 10 Jul 2006 00:40:02 -0700 From: Ralph Goers Reply-To: rgoers@apache.org User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: Wildcard matcher causes StackOverflowErrors (was Re: StackOverflowError in 2.1) References: <44B1E9B7.4040706@dslextreme.com> <44B1F300.4070708@dslextreme.com> <44B1FFCE.2020402@dslextreme.com> <44B20121.8080004@apache.org> In-Reply-To: <44B20121.8080004@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Carsten Ziegeler wrote: > Ralph Goers schrieb: > >> Were there test cases for the old wildcard matcher? Since this matcher >> is almost certainly used in every Cocoon deployment we must guarantee >> that it is 100% compatible with the old matcher in BRANCH_2_1_X - >> unless, of course, there was some specific bug that needed fixing. >> >> > There were only a few test cases for the old matcher; we have much more > for the new one. And the old one had specific bugs that we needed to fix > and as the old code is very ..ehm..historically grown...it is > unmaintainable. > > Carsten > OK. But my question is really that if the old code didn't have unit tests how do we know that the new unit tests are compatible with the old matcher (i.e - that they get the same results)? I'm not sure what the bugs that needed fixing were, but I would hate to have someone upgrade to 2.1.10 and have them experience a StackOverflowError due to a similar problem. Ralph