From dev-return-88211-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org Mon Jul 03 14:51:14 2006 Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 50855 invoked from network); 3 Jul 2006 14:51:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 Jul 2006 14:51:13 -0000 Received: (qmail 34659 invoked by uid 500); 3 Jul 2006 14:51:12 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 34168 invoked by uid 500); 3 Jul 2006 14:51:11 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 34157 invoked by uid 99); 3 Jul 2006 14:51:11 -0000 Received: from [209.237.227.194] (HELO [127.0.0.1]) (209.237.227.194) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jul 2006 07:51:11 -0700 Message-ID: <44A92EEE.7060401@apache.org> Date: Mon, 03 Jul 2006 16:51:26 +0200 From: Carsten Ziegeler User-Agent: Thunderbird 1.5.0.4 (Windows/20060516) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: CocoonPortlet needs to allow overriding servlet-path parameter with preferences. References: <20060630122243.40916.qmail@web51111.mail.yahoo.com> In-Reply-To: <20060630122243.40916.qmail@web51111.mail.yahoo.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Woon-San Ko wrote: > Hi, all. > > The CocoonPortlet in BRANCH_2_1_X does not allow overriding the *servlet-path* init parameter by > preferences. > So, portal users have to add portlet tags in the portlet.xml whenever they need to use another > coplet in the portal site. > > If the CocoonPortlet reads preferences to override the *servlet-path*, portal users can use many > coplet fragments without tedious portlet tag additions. > Hi, I think this is a good addition to the ManagedCocoonPortlet. Can you please come up with a proper patch that you file into Jira? Every patch should go through our tracking system. If you also could change the code a little bit to avoid the code duplication (by factoring this out into a method) would be great! Thanks Carsten -- Carsten Ziegeler - Open Source Group, S&N AG http://www.s-und-n.de http://www.osoco.org/weblogs/rael/