cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: Wildcard matcher causes StackOverflowErrors (was Re: StackOverflowError in 2.1)
Date Mon, 10 Jul 2006 15:06:23 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 10 Jul 2006, Carsten Ziegeler wrote:

> Date: Mon, 10 Jul 2006 09:26:25 +0200
> From: Carsten Ziegeler <cziegeler@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: Wildcard matcher causes StackOverflowErrors (was Re:
>     StackOverflowError in 2.1)
> 
> Ralph Goers schrieb:
>> Giacomo Pati wrote:
>>> You mean the new WildcardMatcher is not behaving correctly? Any
>>> TestCase to fix it? Is a match="menu/*" catching a uri="foo.html"?
>> No. match="*.html" is matching on "menu/index.html".
>>> I have to check that.
>>>
>>> Ciao
>>>
>>> Giacomo
>> Were there test cases for the old wildcard matcher?  Since this matcher
>> is almost certainly used in every Cocoon deployment we must guarantee
>> that it is 100% compatible with the old matcher in BRANCH_2_1_X -
>> unless, of course, there was some specific bug that needed fixing.
>>
> There were only a few test cases for the old matcher; we have much more
> for the new one. And the old one had specific bugs that we needed to fix
> and as the old code is very ..ehm..historically grown...it is
> unmaintainable.

The "old MatcherTestCase" uses the ExcaliburTestCase (or such) to 
establish a test environment whereas the "new MatcherTestCase" just a 
plain JUnit TestCase as the base class. I've fixed the problem of the 
"new Matcher" but will leave the exercise of what Sylvain explained to 
others.

Ciao

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)

iD8DBQFEsmzvLNdJvZjjVZARAlbGAJoCW0m2virHu5A3RpWcHOwEzYra4ACdGxgU
mEjJLwhUH8JsnNlrIx4ArQU=
=quYR
-----END PGP SIGNATURE-----

Mime
View raw message