Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Date: Wed, 28 Jun 2006 09:55:59 +0200 (CEST)
From: Giacomo Pati <giacomo@apache.org>
Sender: giacomo@lapgp.otego.com
To: dev@cocoon.apache.org
Subject: Re: svn commit: r417489 -  
 /cocoon/branches/BRANCH_2_1_X/src/test/org/apache/cocoon/matching/WildcardURIMatcherTestCase.java
In-Reply-To: <e7tamj$f3o$1@sea.gmane.org>
Message-ID: <Pine.LNX.4.64.0606280952520.5401@lapgp.otego.com>
References: <20060627153935.EB6421A983A@eris.apache.org>
 <Pine.LNX.4.64.0606272214300.30023__30634.0038813234$1151439360$gmane$org@zeus.otego.com>
 <e7tamj$f3o$1@sea.gmane.org>
X-GPG-PUBLIC_KEY: 
 http://pks.gpg.cz:11371/pks/lookup?op=get&search=0x2CD749BD98E35590
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 28 Jun 2006, Andreas Hartmann wrote:

> Date: Wed, 28 Jun 2006 09:21:54 +0200
> From: Andreas Hartmann <andreas@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: svn commit: r417489 -
>     /cocoon/branches/BRANCH_2_1_X/src/test/org/apache/cocoon/matching/Wildcard
>     URIMatcherTestCase.java
> 
> Giacomo Pati wrote:
>>  On Tue, 27 Jun 2006, andreas@apache.org wrote:
>> 
>> >  Date: Tue, 27 Jun 2006 15:39:35 -0000
>> >  From: andreas@apache.org
>> >  Reply-To: dev@cocoon.apache.org
>> >  To: cvs@cocoon.apache.org
>> >  Subject: svn commit: r417489 -
>> >      /cocoon/branches/BRANCH_2_1_X/src/test/org/apache/cocoon/matching/Wildcard 
>> > 
>> >      URIMatcherTestCase.java
>> > 
>> >  Author: andreas
>> >  Date: Tue Jun 27 08:39:35 2006
>> >  New Revision: 417489
>> > 
>> >  URL: http://svn.apache.org/viewvc?rev=417489&view=rev
>> >  Log:
>> >  Added failing test to WildcardURIMatcherTestCase: **/*.html results in 
>> >  wrong wildcard replacements
>>
>>  I'll have a look at it tomorrow.
>
> That would be great, thanks a lot!
>
> I took a quick look at WildcardMatcherHelper.Matcher.match(), but it
> looked a little to complex. I guess the problem is that the double
> asterisk is not greedy enough, but I have no idea how to fix it :)

Yes, it's exaclty that. I've changed the greedyness of the '**' wildcard 
with the consequence that other test cases now won't deliver same 
results (all having multiple '**' wildcards, and thus have changed them 
accordingly).

> I wondered, though, that the Javadocs say that the method works from
> the end to the start, but it looks like it actually works from the
> start to the end - maybe it's related to that?

Hmm.. I thought I've changed all the javadocs accordingly. The first 
algorithm was processing from end to start but this as shown to be more 
complex in the end so I've change it from start to end. I'll checck the 
javadocs again. Tnanks.

Ciao

Giacomo

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEojYRLNdJvZjjVZARAnb2AKDVR+Rm11Ir6eWkTC/6gGBVkESguACgvOuu
HN/hL5O/xrLB8PrMIyA8Nu4=
=zZur
-----END PGP SIGNATURE-----