cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: Please review changes to WildcardHelper
Date Thu, 22 Jun 2006 09:42:42 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 22 Jun 2006, Carsten Ziegeler wrote:

> Date: Thu, 22 Jun 2006 11:30:42 +0200
> From: Carsten Ziegeler <cziegeler@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: Please review changes to WildcardHelper
> 
> Giacomo Pati wrote:
>> On Thu, 22 Jun 2006, Carsten Ziegeler wrote:
>
>>>> *Today* I looked at the code (sorry for now looking at it yesterday :)
>>>> ), and I think it looks really good. I added some more test cases and
>>>> added the code to 2.1.x and also switched to your now code.
>>>> I'm currently testing and if it looks good I'll commit it.
>>
>> Oh, ok, you've beaten me. Thanks.
>>
> I just found a bug; I added a new test case (21) for it. I guess it's
> because of the trailing '/' in the uri?

I've seen your commit. I'll have a look at it.

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEmmYTLNdJvZjjVZARAsoCAKC6lcyJsWyAE6of0Heoqq62W/cVBgCgxT6y
bv2hD3G8rp+/LdvmoWGoR3U=
=v3FY
-----END PGP SIGNATURE-----

Mime
View raw message