cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: Please review changes to WildcardHelper
Date Thu, 22 Jun 2006 08:40:00 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 20 Jun 2006, Giacomo Pati wrote:

> Date: Tue, 20 Jun 2006 14:01:17 +0200 (CEST)
> From: Giacomo Pati <giacomo@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: Please review changes to WildcardHelper
> 
> --[PinePGP]--------------------------------------------------[begin]--
> On Tue, 20 Jun 2006, Giacomo Pati wrote:
>
>>  I'll do a quick check whether our test cases pass with the mentioned
>>  class.
>
> Uh, it's not conforming to our "pattern definition" (escaping, character
> '?' ) and inserting code to grab the matched part might become heavy.
> Giving up.

I've written a new WildcardMatcherHelper class fron ground up as well as 
a TestCase for it. Please review especially the TestCase and add cases 
you think wasn't tested so far (the original test case had as few as 3 
tests where the new one already has 19 tests and I still feel there 
could be more).

If people think we should switch to the new one give me a go and I'll 
do.

TIA

Giacomo

  >
> --
> Giacomo Pati
> Otego AG, Switzerland - http://www.otego.com
> Orixo, the XML business alliance - http://www.orixo.com
> --[PinePGP]-----------------------------------------------------------
> gpg:  Signature made Tue Jun 20 14:01:22 2006 CEST using DSA key ID 98E35590
> gpg:  Good signature from "Giacomo Pati <giacomo@otego.com>"
> gpg:                  aka "Giacomo Pati <giacomo@apache.org>"
> gpg:                  aka "Giacomo Pati <giacomo@pati.ch>"
> --[PinePGP]----------------------------------------------------[end]--
>
>

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEmldiLNdJvZjjVZARAskqAJ9qyBx9gfOm5P31Vk+3U1ha6UKwGgCdFWjq
SWUVB1V9movUaWBsDa65Qbk=
=IHvL
-----END PGP SIGNATURE-----

Mime
View raw message