cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: Please review changes to WildcardHelper
Date Tue, 20 Jun 2006 07:52:17 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 19 Jun 2006, Carsten Ziegeler wrote:

> Date: Mon, 19 Jun 2006 18:23:29 +0200
> From: Carsten Ziegeler <cziegeler@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: Please review changes to WildcardHelper
> 
> Giacomo Pati wrote:
>> How about using the Ant code (as the Wildcard syntax was borrowed from
>> it)? Either using the Ant code directly (introducing a runtime
>> dependency to Ant) or copy the code?
>>
>> As we use spring now, now about the class
>> org.springframework.util.AntPathMatcher?
>>
> Yes, I thought about using the Ant code as well - do you know which
> class it is?
>
> Now, I think we can't directly use existing code, but have to copy it as
> we need to know whether a uri matches *and* if it matches we need to
> know the current values for the placeholders. At least the spring code
> does not provide this information.
>
> I think I will copy the code from one of those projects and use that as
> a base.

I'd suggest using the org.springframework.util.AntPathMatcher code as it 
doesn't have an additional dependency (not even on Ant). Perhaps using 
our test cases against it would help to see whether that code is 
sufficient (ATM) for us. And if it is it wouldn't be that hard to 
integrate the fragment extraction logic into it I guess (assuming we 
copy that 
code).

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEl6kyLNdJvZjjVZARAqhrAJoDDNwPpFukAL5Bs9AmQr/rv9bNMwCfW7kM
JlBHRUUmIlTbHtlJ55MIuok=
=Y7Kd
-----END PGP SIGNATURE-----

Mime
View raw message