cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: Please review changes to WildcardHelper
Date Mon, 19 Jun 2006 15:22:28 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 19 Jun 2006, Giacomo Pati wrote:

> Date: Mon, 19 Jun 2006 17:15:14 +0200 (CEST)
> From: Giacomo Pati <giacomo@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: Please review changes to WildcardHelper
> 
> --[PinePGP]--------------------------------------------------[begin]--
> On Mon, 19 Jun 2006, Carsten Ziegeler wrote:
>
>>  Date: Mon, 19 Jun 2006 15:51:04 +0200
>>  From: Carsten Ziegeler <cziegeler@apache.org>
>>  Reply-To: dev@cocoon.apache.org
>>  To: dev@cocoon.apache.org
>>  Subject: Re: Please review changes to WildcardHelper
>>
>>  Andreas Hartmann wrote:
>> > > > 
>> > > >         <map:match pattern="*/">
>> > > >           <map:redirect-to uri="introduction.html"/>
>> > > >         </map:match>
>> > > > 
>> > > >  After the change, this matches all URLs ending with a slash,
>> > > >  even ones containing slashes. This is not intended, is it?
>> > > > 
>> > >  No, it's definitly not. This is a bug, I'll add your test case.
>> > 
>> >  OK, thanks a lot!
>> >
>>  Ok, I fixed this one, but I'm getting more and more unhappy with the
>>  code; perhaps a clean rewrite would help...
>
> How about using the Ant code (as the Wildcard syntax was borrowed from
> it)? Either using the Ant code directly (introducing a runtime
> dependency to Ant) or copy the code?

As we use spring now, now about the class 
org.springframework.util.AntPathMatcher?

>
> --
> Giacomo Pati
> Otego AG, Switzerland - http://www.otego.com
> Orixo, the XML business alliance - http://www.orixo.com
> --[PinePGP]-----------------------------------------------------------
> gpg:  Signature made Mon Jun 19 17:15:19 2006 CEST using DSA key ID 98E35590
> gpg:  Good signature from "Giacomo Pati <giacomo@otego.com>"
> gpg:                  aka "Giacomo Pati <giacomo@apache.org>"
> gpg:                  aka "Giacomo Pati <giacomo@pati.ch>"
> --[PinePGP]----------------------------------------------------[end]--
>

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFElsE1LNdJvZjjVZARAgZ5AKDF+GNi29k0JYnQbl1Mr1tCmkL88wCgvnTJ
xmKgMZDiKZTrNjQ66Lho8Vc=
=/Azf
-----END PGP SIGNATURE-----

Mime
View raw message