cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josias Thöny <josias.tho...@wyona.com>
Subject Re: Please review changes to WildcardHelper
Date Tue, 20 Jun 2006 14:29:58 GMT
On Mon, 2006-06-19 at 15:51 +0200, Carsten Ziegeler wrote:
> Andreas Hartmann wrote:
> >>>
> >>>        <map:match pattern="*/">
> >>>          <map:redirect-to uri="introduction.html"/>
> >>>        </map:match>
> >>>
> >>> After the change, this matches all URLs ending with a slash,
> >>> even ones containing slashes. This is not intended, is it?
> >>>
> >> No, it's definitly not. This is a bug, I'll add your test case.
> > 
> > OK, thanks a lot!
> > 
> Ok, I fixed this one, but I'm getting more and more unhappy with the
> code; perhaps a clean rewrite would help...

Thanks for the fix!
But somehow there still seems to be a problem with "*/" matching more
than it should.

If I change the URL in the testcase from "foo/bar/" to "test/foo/bar/",
it matches "*/" and the testcase fails. (See attached diff)

Is this another bug or did I miss something?

Josias

> 
> Carsten
> 

Mime
View raw message