Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 81539 invoked from network); 12 May 2006 15:32:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 May 2006 15:32:19 -0000 Received: (qmail 2090 invoked by uid 500); 12 May 2006 15:32:17 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 2025 invoked by uid 500); 12 May 2006 15:32:16 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 2014 invoked by uid 99); 12 May 2006 15:32:16 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2006 08:32:16 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [195.216.81.147] (HELO mail.otego.com) (195.216.81.147) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2006 08:32:15 -0700 Received: (qmail 10562 invoked from network); 12 May 2006 17:31:51 +0200 Received: from 192.168.222.3 by zeus (envelope-from , uid 201) with qmail-scanner-1.25st (clamdscan: 0.88.1/1374. perlscan: 1.25st. Clear:RC:1(192.168.222.3):. Processed in 0.036894 secs); 12 May 2006 15:31:51 -0000 Received: from unknown (HELO localhost) (192.168.222.3) by 0 with (DHE-RSA-AES256-SHA encrypted) SMTP; 12 May 2006 17:31:51 +0200 Date: Fri, 12 May 2006 17:31:48 +0200 (CEST) From: Giacomo Pati Sender: giacomo@lapgp.otego.com To: dev@cocoon.apache.org Subject: Re: CallFunctionNode problems in trunk In-Reply-To: Message-ID: References: <446473E9.6060207@apache.org> <44648C37.60101@apache.org> <446491B2.8040009@apache.org> <446493A9.6080509@apache.org> <4464961C.9010207@apache.org> <44649A7E.6080704@apache.org> X-GPG-FINGRPRINT: 9E66 40E0 0A9C B37F E29E 5816 2CD7 49BD 98E3 5590 X-GPG-PUBLIC_KEY: http://pks.gpg.cz:11371/pks/lookup?op=get&search=0x2CD749BD98E35590 MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1948772031-1147447908=:27721" X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1948772031-1147447908=:27721 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I've something working for an app I'm migrating to cocoon-2.2. Could one of the other bug hunters check if the attached patch works for her, too? If so that patch could be a base for how to solve this issue. TIA and have a nice weekend! Giacomo On Fri, 12 May 2006, Giacomo Pati wrote: > Date: Fri, 12 May 2006 16:56:28 +0200 (CEST) > From: Giacomo Pati > Reply-To: dev@cocoon.apache.org > To: dev@cocoon.apache.org > Subject: Re: CallFunctionNode problems in trunk > > --[PinePGP]--------------------------------------------------[begin]-- > > On Fri, 12 May 2006, Carsten Ziegeler wrote: > >> Date: Fri, 12 May 2006 16:23:58 +0200 >> From: Carsten Ziegeler >> Reply-To: dev@cocoon.apache.org >> To: dev@cocoon.apache.org >> Subject: Re: CallFunctionNode problems in trunk >> >> Giacomo Pati schrieb: >> > On Fri, 12 May 2006, Carsten Ziegeler wrote: >> > >> > > > Date: Fri, 12 May 2006 16:05:16 +0200 >> > > > From: Carsten Ziegeler >> > > > Reply-To: dev@cocoon.apache.org >> > > > To: dev@cocoon.apache.org >> > > > Subject: Re: CallFunctionNode problems in trunk >> > > > >> > > > Reinhard Poetz schrieb: >> > > > > Carsten Ziegeler wrote: >> > > > > > Ignore my last email - the current code is correct. The >> > > > > > singleton >> > > > > > variable is set to false some lines below :( >> > > > > Just wanted to answer that it doesn't fix it. IIUC the container >> > > > > with the >> > > > > builders is setup in SitemapLanguage.java#405-430. But I don't >> > > > > understand how >> > > > > the selector gets filled with all the builders ... >> > > > > >> > > > Yes, the code is correct. The problem is in the selector (see my >> > > > reply >> > > > to Giacomo's mail). I think we should fix the node builder: I guess >> > > > if >> > >> > I've browsed through alost all NodeBuilders and have seen that we have >> > to fix alot of them (many aren't singletons) >> > >> > > > it would use a list of simple beans (where the bean contains the >> > > > resource name, function name etc), and then process this list in >> > > > linkNode() it should work. >> > >> > Well, this is another problem as those values (resource name, function >> > name, ...) are held in member variables too :-( and the linkNode method >> > needs a way to distinguish them (but hase no argument to check for). >> > >> Ok, so let's change the strategy and fix the standalone service >> selector... :) If svn works again I can do this on monday evening - if >> noone beats me to it. > > I've made a quich hack to see if that will help (and maybe I'm looking > at the wrong place): > > Index: > src/main/java/org/apache/cocoon/components/treeprocessor/StandaloneServiceSelector.java > =================================================================== > --- > src/main/java/org/apache/cocoon/components/treeprocessor/StandaloneServiceSelector.java > (revision 405757) > +++ > src/main/java/org/apache/cocoon/components/treeprocessor/StandaloneServiceSelector.java > (working copy) > @@ -38,6 +38,7 @@ > import org.apache.avalon.framework.service.ServiceManager; > import org.apache.avalon.framework.service.ServiceSelector; > import org.apache.avalon.framework.service.Serviceable; > +import org.apache.avalon.framework.thread.ThreadSafe; > import org.apache.cocoon.core.container.spring.ComponentInfo; > import org.apache.cocoon.util.ClassUtils; > > @@ -107,7 +108,11 @@ > info.setRole(role); > info.setConfiguration(configuration); > info.setComponentClassName(componentClass.getName()); > - info.setModel(ComponentInfo.MODEL_SINGLETON); > + if (ThreadSafe.class.isAssignableFrom(componentClass)) { > + info.setModel(ComponentInfo.MODEL_SINGLETON); > + } else { > + info.setModel(ComponentInfo.MODEL_PRIMITIVE); > + } > return info; > } > > Doesn't get me any further. Still getting > > java.lang.NullPointerException > at > org.apache.cocoon.components.treeprocessor.sitemap.CallFunctionNode.invoke(CallFunctionNode.java:113) > > Any additional ideas? > > -- > Giacomo Pati > Otego AG, Switzerland - http://www.otego.com > Orixo, the XML business alliance - http://www.orixo.com > --[PinePGP]----------------------------------------------------------- > gpg: Signature made Fri May 12 16:56:29 2006 CEST using DSA key ID 98E35590 > gpg: Good signature from "Giacomo Pati " > gpg: aka "Giacomo Pati " > gpg: aka "Giacomo Pati " > --[PinePGP]----------------------------------------------------[end]-- > - -- Giacomo Pati Otego AG, Switzerland - http://www.otego.com Orixo, the XML business alliance - http://www.orixo.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFEZKplLNdJvZjjVZARAl5tAKCqRsQJCQXkBdLPXtOV+sWpBC8izgCaAzBU LZdrWbJlBdI76MYvn9rq/Qs= =ZTOJ -----END PGP SIGNATURE----- --8323328-1948772031-1147447908=:27721 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=CallNodeBuilder.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=CallNodeBuilder.patch SW5kZXg6IHNyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jb2Nvb24vY29tcG9u ZW50cy90cmVlcHJvY2Vzc29yL3NpdGVtYXAvQ2FsbE5vZGVCdWlsZGVyLmph dmENCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBzcmMvbWFpbi9qYXZh L29yZy9hcGFjaGUvY29jb29uL2NvbXBvbmVudHMvdHJlZXByb2Nlc3Nvci9z aXRlbWFwL0NhbGxOb2RlQnVpbGRlci5qYXZhCShyZXZpc2lvbiA0MDU3NTcp DQorKysgc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvY29vbi9jb21wb25l bnRzL3RyZWVwcm9jZXNzb3Ivc2l0ZW1hcC9DYWxsTm9kZUJ1aWxkZXIuamF2 YQkod29ya2luZyBjb3B5KQ0KQEAgLTE2LDYgKzE2LDcgQEANCiBwYWNrYWdl IG9yZy5hcGFjaGUuY29jb29uLmNvbXBvbmVudHMudHJlZXByb2Nlc3Nvci5z aXRlbWFwOw0KIA0KIGltcG9ydCBqYXZhLnV0aWwuQXJyYXlMaXN0Ow0KK2lt cG9ydCBqYXZhLnV0aWwuSXRlcmF0b3I7DQogaW1wb3J0IGphdmEudXRpbC5M aXN0Ow0KIA0KIGltcG9ydCBvcmcuYXBhY2hlLmF2YWxvbi5mcmFtZXdvcmsu Y29uZmlndXJhdGlvbi5Db25maWd1cmFibGU7DQpAQCAtMzYsMTkgKzM3LDE0 IEBADQogcHVibGljIGNsYXNzIENhbGxOb2RlQnVpbGRlciBleHRlbmRzIEFi c3RyYWN0UHJvY2Vzc2luZ05vZGVCdWlsZGVyDQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpbXBsZW1lbnRzIExpbmtlZFByb2Nlc3NpbmdOb2Rl QnVpbGRlciB7DQogDQotICAgIHByb3RlY3RlZCBQcm9jZXNzaW5nTm9kZSBu b2RlOw0KKyAgICBwcm90ZWN0ZWQgTGlzdCBub2RlcyA9IG5ldyBBcnJheUxp c3QoKTsNCiANCi0gICAgcHJvdGVjdGVkIFN0cmluZyByZXNvdXJjZU5hbWU7 DQotDQotICAgIHByb3RlY3RlZCBTdHJpbmcgZnVuY3Rpb25OYW1lOw0KLQ0K LSAgICBwcm90ZWN0ZWQgU3RyaW5nIGNvbnRpbnVhdGlvbklkOw0KLQ0KICAg ICBwdWJsaWMgUHJvY2Vzc2luZ05vZGUgYnVpbGROb2RlKENvbmZpZ3VyYXRp b24gY29uZmlnKQ0KICAgICB0aHJvd3MgRXhjZXB0aW9uIHsNCi0gICAgICAg IHJlc291cmNlTmFtZSA9IGNvbmZpZy5nZXRBdHRyaWJ1dGUoInJlc291cmNl IiwgbnVsbCk7DQotICAgICAgICBmdW5jdGlvbk5hbWUgPSBjb25maWcuZ2V0 QXR0cmlidXRlKCJmdW5jdGlvbiIsIG51bGwpOw0KLSAgICAgICAgY29udGlu dWF0aW9uSWQgPSBjb25maWcuZ2V0QXR0cmlidXRlKCJjb250aW51YXRpb24i LCBudWxsKTsNCisgICAgICAgIFByb2Nlc3NpbmdOb2RlIG5vZGU7DQorICAg ICAgICBTdHJpbmcgcmVzb3VyY2VOYW1lID0gY29uZmlnLmdldEF0dHJpYnV0 ZSgicmVzb3VyY2UiLCBudWxsKTsNCisgICAgICAgIFN0cmluZyBmdW5jdGlv bk5hbWUgPSBjb25maWcuZ2V0QXR0cmlidXRlKCJmdW5jdGlvbiIsIG51bGwp Ow0KKyAgICAgICAgU3RyaW5nIGNvbnRpbnVhdGlvbklkID0gY29uZmlnLmdl dEF0dHJpYnV0ZSgiY29udGludWF0aW9uIiwgbnVsbCk7DQogDQogICAgICAg ICBpZiAocmVzb3VyY2VOYW1lID09IG51bGwpIHsNCiAgICAgICAgICAgICAv LyBCdWlsZGluZyBhIENhbGxGdW5jdGlvbiBub2RlDQpAQCAtODMsMTYgKzc5 LDIxIEBADQogICAgICAgICAgICAgbm9kZSA9IG5ldyBDYWxsTm9kZSgpOw0K ICAgICAgICAgfQ0KIA0KLSAgICAgICAgdGhpcy50cmVlQnVpbGRlci5zZXR1 cE5vZGUodGhpcy5ub2RlLCBjb25maWcpOw0KKyAgICAgICAgdGhpcy50cmVl QnVpbGRlci5zZXR1cE5vZGUobm9kZSwgY29uZmlnKTsNCiAgICAgICAgIGlm IChub2RlIGluc3RhbmNlb2YgQ29uZmlndXJhYmxlKSB7DQotICAgICAgICAg ICAgKChDb25maWd1cmFibGUpIHRoaXMubm9kZSkuY29uZmlndXJlKGNvbmZp Zyk7DQorICAgICAgICAgICAgKChDb25maWd1cmFibGUpIG5vZGUpLmNvbmZp Z3VyZShjb25maWcpOw0KICAgICAgICAgfQ0KIA0KLSAgICAgICAgcmV0dXJu IHRoaXMubm9kZTsNCisgICAgICAgIG5vZGVzLmFkZChuZXcgTm9kZUl0ZW0o cmVzb3VyY2VOYW1lLCBub2RlKSk7DQorICAgICAgICByZXR1cm4gbm9kZTsN CiAgICAgfQ0KIA0KICAgICBwdWJsaWMgdm9pZCBsaW5rTm9kZSgpIHRocm93 cyBFeGNlcHRpb24gew0KLSAgICAgICAgaWYgKHJlc291cmNlTmFtZSAhPSBu dWxsKSB7DQorICAgICAgICBmb3IgKGZpbmFsIEl0ZXJhdG9yIGkgPSBub2Rl cy5pdGVyYXRvcigpOyBpLmhhc05leHQoKTspIHsNCisgICAgICAgICAgICBO b2RlSXRlbSBub2RlSXRlbSA9IChOb2RlSXRlbSlpLm5leHQoKTsNCisgICAg ICAgICAgICBTdHJpbmcgcmVzb3VyY2VOYW1lID0gbm9kZUl0ZW0ucmVzb3Vy Y2VOYW1lOw0KKyAgICAgICAgICAgIFByb2Nlc3NpbmdOb2RlIG5vZGUgPSBu b2RlSXRlbS5ub2RlOw0KKyAgICAgICAgICAgIGlmIChyZXNvdXJjZU5hbWUg IT0gbnVsbCkgew0KICAgICAgICAgICAgIC8vIFdlIGhhdmUgYSA8bWFwOmNh bGwgcmVzb3VyY2U9Ii4uLiIvPg0KICAgICAgICAgICAgIENhdGVnb3J5Tm9k ZSByZXNvdXJjZXMgPSBDYXRlZ29yeU5vZGVCdWlsZGVyLmdldENhdGVnb3J5 Tm9kZSh0cmVlQnVpbGRlciwgInJlc291cmNlcyIpOw0KIA0KQEAgLTEwMCwy NyArMTAxLDM3IEBADQogICAgICAgICAgICAgICAgIHRocm93IG5ldyBDb25m aWd1cmF0aW9uRXhjZXB0aW9uKA0KICAgICAgICAgICAgICAgICAgICAgIlRo aXMgc2l0ZW1hcCBjb250YWlucyBubyByZXNvdXJjZXMuIENhbm5vdCBjYWxs IGF0ICIgKyBub2RlLmdldExvY2F0aW9uKCkpOw0KIA0KLSAgICAgICAgICAg ICgoQ2FsbE5vZGUpIHRoaXMubm9kZSkuc2V0UmVzb3VyY2UoDQotICAgICAg ICAgICAgICAgIHJlc291cmNlcywNCi0gICAgICAgICAgICAgICAgVmFyaWFi bGVSZXNvbHZlckZhY3RvcnkuZ2V0UmVzb2x2ZXIodGhpcy5yZXNvdXJjZU5h bWUsIHRoaXMubWFuYWdlcikNCisgICAgICAgICAgICAoKENhbGxOb2RlKSBu b2RlKS5zZXRSZXNvdXJjZSgNCisgICAgICAgICAgICAgICAgICAgICAgICBy ZXNvdXJjZXMsDQorICAgICAgICAgICAgICAgICAgICAgICAgVmFyaWFibGVS ZXNvbHZlckZhY3RvcnkuZ2V0UmVzb2x2ZXIocmVzb3VyY2VOYW1lLCB0aGlz Lm1hbmFnZXIpDQogICAgICAgICAgICAgKTsNCi0gICAgICAgIH0gZWxzZSB7 DQotICAgICAgICAgICAgLy8gV2UgaGF2ZSBhIDxtYXA6Y2FsbD4gd2l0aCBl aXRoZXIgImZ1bmN0aW9uIiBvcg0KLSAgICAgICAgICAgIC8vICJjb250aW51 YXRpb24iLCBvciBib3RoIHNwZWNpZmllZA0KKyAgICAgICAgICAgIH0gZWxz ZSB7DQorICAgICAgICAgICAgICAgIC8vIFdlIGhhdmUgYSA8bWFwOmNhbGw+ IHdpdGggZWl0aGVyICJmdW5jdGlvbiIgb3INCisgICAgICAgICAgICAgICAg Ly8gImNvbnRpbnVhdGlvbiIsIG9yIGJvdGggc3BlY2lmaWVkDQogDQotICAg ICAgICAgICAgLy8gQ2hlY2sgdG8gc2VlIGlmIGEgZmxvdyBoYXMgYmVlbiBk ZWZpbmVkIGluIHRoaXMgc2l0ZW1hcA0KLSAgICAgICAgICAgIEZsb3dOb2Rl IGZsb3cgPSAoRmxvd05vZGUpIHRyZWVCdWlsZGVyLmdldFJlZ2lzdGVyZWRO b2RlKCJmbG93Iik7DQotICAgICAgICAgICAgaWYgKGZsb3cgPT0gbnVsbCkg ew0KLSAgICAgICAgICAgICAgICB0aHJvdyBuZXcgQ29uZmlndXJhdGlvbkV4 Y2VwdGlvbigNCi0gICAgICAgICAgICAgICAgICAgICJUaGlzIHNpdGVtYXAg Y29udGFpbnMgbm8gY29udHJvbCBmbG93cyBkZWZpbmVkLCBjYW5ub3QgY2Fs bCBhdCAiDQotICAgICAgICAgICAgICAgICAgICArIG5vZGUuZ2V0TG9jYXRp b24oKQ0KLSAgICAgICAgICAgICAgICAgICAgKyAiLiBEZWZpbmUgYSBjb250 cm9sIGZsb3cgdXNpbmcgPG1hcDpmbG93Piwgd2l0aCBlbWJlZGRlZCA8bWFw OnNjcmlwdD4gZWxlbWVudHMuIik7DQorICAgICAgICAgICAgICAgIC8vIENo ZWNrIHRvIHNlZSBpZiBhIGZsb3cgaGFzIGJlZW4gZGVmaW5lZCBpbiB0aGlz IHNpdGVtYXANCisgICAgICAgICAgICAgICAgRmxvd05vZGUgZmxvdyA9IChG bG93Tm9kZSkgdHJlZUJ1aWxkZXIuZ2V0UmVnaXN0ZXJlZE5vZGUoImZsb3ci KTsNCisgICAgICAgICAgICAgICAgaWYgKGZsb3cgPT0gbnVsbCkgew0KKyAg ICAgICAgICAgICAgICAgICAgdGhyb3cgbmV3IENvbmZpZ3VyYXRpb25FeGNl cHRpb24oDQorICAgICAgICAgICAgICAgICAgICAgICAgIlRoaXMgc2l0ZW1h cCBjb250YWlucyBubyBjb250cm9sIGZsb3dzIGRlZmluZWQsIGNhbm5vdCBj YWxsIGF0ICINCisgICAgICAgICAgICAgICAgICAgICAgICArIG5vZGUuZ2V0 TG9jYXRpb24oKQ0KKyAgICAgICAgICAgICAgICAgICAgICAgICsgIi4gRGVm aW5lIGEgY29udHJvbCBmbG93IHVzaW5nIDxtYXA6Zmxvdz4sIHdpdGggZW1i ZWRkZWQgPG1hcDpzY3JpcHQ+IGVsZW1lbnRzLiIpOw0KKyAgICAgICAgICAg ICAgICB9DQorDQorICAgICAgICAgICAgICAgIC8vIEdldCB0aGUgSW50ZXJw cmV0ZXIgaW5zdGFuY2UgYW5kIHNldCBpdCB1cCBpbiB0aGUNCisgICAgICAg ICAgICAgICAgLy8gQ2FsbEZ1bmN0aW9uTm9kZSBmdW5jdGlvbg0KKyAgICAg ICAgICAgICAgICBJbnRlcnByZXRlciBpbnRlcnByZXRlciA9IGZsb3cuZ2V0 SW50ZXJwcmV0ZXIoKTsNCisgICAgICAgICAgICAgICAgKChDYWxsRnVuY3Rp b25Ob2RlKSBub2RlKS5zZXRJbnRlcnByZXRlcihpbnRlcnByZXRlcik7DQog ICAgICAgICAgICAgfQ0KKyAgICAgICAgfQ0KKyAgICB9DQogDQotICAgICAg ICAgICAgLy8gR2V0IHRoZSBJbnRlcnByZXRlciBpbnN0YW5jZSBhbmQgc2V0 IGl0IHVwIGluIHRoZQ0KLSAgICAgICAgICAgIC8vIENhbGxGdW5jdGlvbk5v ZGUgZnVuY3Rpb24NCi0gICAgICAgICAgICBJbnRlcnByZXRlciBpbnRlcnBy ZXRlciA9IGZsb3cuZ2V0SW50ZXJwcmV0ZXIoKTsNCi0gICAgICAgICAgICAo KENhbGxGdW5jdGlvbk5vZGUpIG5vZGUpLnNldEludGVycHJldGVyKGludGVy cHJldGVyKTsNCisgICAgcHJpdmF0ZSBzdGF0aWMgY2xhc3MgTm9kZUl0ZW0g ew0KKyAgICAgICAgU3RyaW5nIHJlc291cmNlTmFtZTsNCisgICAgICAgIFBy b2Nlc3NpbmdOb2RlIG5vZGU7DQorICAgICAgICBOb2RlSXRlbShTdHJpbmcg cmVzb3VyY2VOYW1lLCBQcm9jZXNzaW5nTm9kZSBub2RlKSB7DQorICAgICAg ICAgICAgdGhpcy5yZXNvdXJjZU5hbWUgPSByZXNvdXJjZU5hbWU7DQorICAg ICAgICAgICAgdGhpcy5ub2RlID0gbm9kZTsNCiAgICAgICAgIH0NCiAgICAg fQ0KLX0NClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQ0KK30NCg== --8323328-1948772031-1147447908=:27721--