Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 35767 invoked from network); 25 May 2006 21:06:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 May 2006 21:06:30 -0000 Received: (qmail 20379 invoked by uid 500); 25 May 2006 21:06:27 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 20310 invoked by uid 500); 25 May 2006 21:06:27 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 20299 invoked by uid 99); 25 May 2006 21:06:27 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2006 14:06:27 -0700 X-ASF-Spam-Status: No, hits=1.9 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of ats37@hotmail.com designates 65.54.175.18 as permitted sender) Received: from [65.54.175.18] (HELO hotmail.com) (65.54.175.18) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2006 14:06:26 -0700 Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC; Thu, 25 May 2006 14:06:06 -0700 Message-ID: Received: from 65.54.175.200 by by104fd.bay104.hotmail.msn.com with HTTP; Thu, 25 May 2006 21:06:01 GMT X-Originating-IP: [62.49.63.196] X-Originating-Email: [ats37@hotmail.com] X-Sender: ats37@hotmail.com In-Reply-To: <4475F822.8060609@apache.org> From: "Andrew Stevens" To: dev@cocoon.apache.org Subject: Re: [RT] Removing sitemap configurable Date: Thu, 25 May 2006 22:06:01 +0100 Mime-Version: 1.0 Content-Type: text/plain; format=flowed X-OriginalArrivalTime: 25 May 2006 21:06:06.0093 (UTC) FILETIME=[09B723D0:01C6803F] X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N >From: Carsten Ziegeler >Date: Thu, 25 May 2006 20:32:02 +0200 > >Carsten Ziegeler wrote: > > I think we should remove the concept of sitemap configurable components > > from 2.2 completly. > > Today, it is possible that a component implements the > > SitemapConfigurable interface and then one can additionally configure > > this component on a per sitemap base in the map:component-configurations > > section of the sitemap. > > Now this concept is a little bit questionable (ok, it was me who > > introduced it...) and with 2.2 we have the per sitemap configurations > > which make a much cleaner configuration (and therefore implementation). > > > > Only two components are currently using this interface: the global input > > module (not directly) and the authentication manager from the auth-fw. I > > think it's no problem if the configuration of the auth-fw-manager is > > moved into a xconf file and then included from the sitemap. For the > > global input module we now have a much better solution: you can > > configure properties on a per sitemap base (in external files) and the > > new settings input module is able to access these values. The benefit of > > this is that this mechanism also values the running mode, so you can > > have different sets of property files (depending on your running mode - > > prod, test whatever). > > So imho the changes to users are minimal and we completly introduce our > > new configuration concepts and removing the sitemap configurable removes > > some ugly code as well.. > > > > WDYT? > > >Ok, it seems that noone is interested in this old feature anyway. If >noone objects I'll >remove it next week. > >Carsten Presumably it'd still be possible to configure components in the sitemap by (re-)declaring them in the map:components section anyway? Andrew.