Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <22927252.1146837688206.JavaMail.jira@brutus>
Date: Fri, 5 May 2006 14:01:28 +0000 (GMT+00:00)
From: "Ralph Goers (JIRA)" <jira@apache.org>
To: dev@cocoon.apache.org
Subject: [jira] Closed: (COCOON-1742) EncodeURLTransformer can get a
 StackOverflow in jakarta regexp
In-Reply-To: <1134906238.1138394315102.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/COCOON-1742?page=all ]
     
Ralph Goers closed COCOON-1742:
-------------------------------

    Fix Version: 2.2-dev (Current SVN)
                 2.1.10-dev (current SVN)
     Resolution: Fixed

EncodeURLTransformer has been modified to use JDK 1.4 regular expressions.  The modification was released in 2.1.9 but that fix was in error (the error can be circumvented by manually configuring the transformer with expressions that end with wildcards to match the end of the string).  The final fix is in 2.1.10 and in trunk.  The fix is only available in 2.1.10 when compiling with JDK 1.4. JDK 1.3 will still use the old version of the EncodeURLTransformer.

> EncodeURLTransformer can get a StackOverflow in jakarta regexp
> --------------------------------------------------------------
>
>          Key: COCOON-1742
>          URL: http://issues.apache.org/jira/browse/COCOON-1742
>      Project: Cocoon
>         Type: Bug

>   Components: * Cocoon Core
>     Versions: 2.1.8, 2.2-dev (Current SVN)
>     Reporter: Ralph Goers
>     Assignee: Ralph Goers
>      Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)

>
> EncodeURLTransformer uses jakarta regexp and calls RE.match(). This method ends up calling matchNode() which recursively calls itself. This is slow and has the potential of causing a StackOverFlowException .Numerous issues have been opened on jakarta regexp regarding this but there are no plans to address this.  I have run tests that show that regexp is much slower than the JDK regular expressions and also slower than ORO.
> The fix for this will be to modify the EncodeURLTransformer in 2.2-dev to use the JDK regular expressions.  Since the JDK regular expressions are only available in JDK 1.4 they cannot directly be used in the 2.1 branch.  Most likely Oro will be used instead.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira