cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Gallardo (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-844) [PATCH] adding <wd:on-phase> and moving load() and save() to Form.
Date Tue, 30 May 2006 12:16:30 GMT
    [ http://issues.apache.org/jira/browse/COCOON-844?page=comments#action_12413816 ] 

Antonio Gallardo commented on COCOON-844:
-----------------------------------------

I guess a different solution for this issue has been implemented by Carsten, see: http://svn.apache.org/viewvc?rev=410241&view=rev

If yes, please close the issue.

> [PATCH] adding <wd:on-phase> and moving load() and save() to Form.
> ------------------------------------------------------------------
>
>          Key: COCOON-844
>          URL: http://issues.apache.org/jira/browse/COCOON-844
>      Project: Cocoon
>         Type: Bug

>   Components: Blocks: Forms
>     Versions: 2.1.8
>  Environment: Operating System: Linux
> Platform: PC
>     Reporter: Ramy Mamdouh
>     Assignee: Cocoon Developers Team
>  Attachments: woody-changes.diff
>
> Hi,
> This is a patch file for the woody block, which contains :
> - adding <wd:on-phase> for the form definition, which define a phase listener on
> the form.
> - making load() and save() part of the Form class, with minimum changes to the
> woody interfaces.
> --------------------
> the patch was created using a command :
>  $COCOON_HOME/src/blocks/woody> cvs diff -u > woody-changes.diff
> -------------------
> The changed files :
> - java/org/apache/cocoon/woody/flow/javascript/woody2.js
> - java/org/apache/cocoon/woody/formmodel/AbstractWidgetDefinitionBuilder.java
> - java/org/apache/cocoon/woody/formmodel/Form.java
> - java/org/apache/cocoon/woody/formmodel/FormDefinition.java
> - java/org/apache/cocoon/woody/formmodel/FormDefinitionBuilder.java
> ------------------
> TODO :
> ------
> - The patch didn't change any interface methods to maintain a comptability for
> other blocks (like Apples),
> I think if this patch is accepted, some interfaces might need changes for making
> the code better, like FormManager.createForm(Source source),
> to add the binding source as well, and remove the binding construction from
> woody2.js
> - cleaning up the TODO and FIXME added to show what changes were made.
> - Listeners are limited to only one listener per difinition ( single listener
> variable),
> that should be be fixed to allow multiple listsners from the same type?
> like many action listsner on the same action widget?
> - To add <wd:on-phase>, I had to change buildAnotherWidgetDefinition() method,
> This method was throwing exception if there's no builder for the the "wd" element,
> what do you think?
> - Make the avalon cycled widget listeners.
> - Write some documentations about the new stuff [partialy done].

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message