Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <621420464.1141832319895.JavaMail.jira@ajax>
Date: Wed, 8 Mar 2006 15:38:39 +0000 (GMT)
From: "Max Pfingsthorn (JIRA)" <jira@apache.org>
To: dev@cocoon.apache.org
Subject: [jira] Commented: (COCOON-1794) [PATCH] Propagation of namespaces
 to a repeaters child bindings and implementation of a move-node binding
In-Reply-To: <591369629.1141731878807.JavaMail.jira@ajax>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/COCOON-1794?page=comments#action_12369471 ] 

Max Pfingsthorn commented on COCOON-1794:
-----------------------------------------

Sorry, that is not right. The repeater will _always_ save rows in order, the only thing that is appended are placeholders to extend the list.
Actually, your usecase should work right now without changes to the repeater binding (other than the ones for the namespaces) since you use a wrapper element.

My change is that new placeholder elements for rows are appended to the bulk of existing row elements instead of at the end of the parent element. That keeps chunks of row data together instead of splitting them when no wrapper element is available.

Your move binding will actually never do anything, as you pointed out, because the rows are saved in order. Of course, the only thing you have to do is to assign new ids to new rows, but I guess you already took care of that.


> [PATCH] Propagation of namespaces to a repeaters child bindings and implementation of a move-node binding
> ---------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1794
>          URL: http://issues.apache.org/jira/browse/COCOON-1794
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Suzan Foster
>  Attachments: repeater-binding-patch.txt
>
> This patch corrects the following issues:
> - Namespaced back-end XML model not correctly binding to the repeaters child widgets.
> - Nodes bound to row widgets not being reordered according to row position on save.
> Files affected:
> - JXPathBindingBase:
>   - member applyLeniency changed from private to protected.
>   - member applyNSDeclarations changed from private to protected.
> - RepeaterJXPathBinding:
>   - constructor changed for passing a binding for moveRow.
>   - applyLeniency and applyNSDeclarations applied to created relative contexts.
>   - member moveRowBinding added.
>   - method getMoveRowBinding added.
>   - doSave changed to incorporate the use of moveRowBinding.
> - RepeaterJXPathBindingBuilder:
>   - buildBinding changed to incorporate the construction of moveRowBinding.
> Files added:
> - MoveNodeJXPathBinding.
> - MoveNodeJXPathBindingBuilder.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira