Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <532161236.1143729266758.JavaMail.jira@ajax>
Date: Thu, 30 Mar 2006 15:34:26 +0100 (BST)
From: "Simone Gianni (JIRA)" <jira@apache.org>
To: dev@cocoon.apache.org
Subject: [jira] Updated: (COCOON-1818) SendMailTransformer misses closing
 tag when recipient address is malformed
In-Reply-To: <1121896843.1143641301078.JavaMail.jira@ajax>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/COCOON-1818?page=all ]

Simone Gianni updated COCOON-1818:
----------------------------------

    Attachment: sendmail-exceptions2.diff

This patch applies the solution number 3 : for every call to the sendMail() method a result element is always generated. It will contain an error, an exception, or the common email sent results. 

This changes the produced XML in many ways :
- The error element was not conained in a result before this patch.
- The exception element was or was not contained in a result before this patch (and this caused the main problems)

So consider that after applying you'll probably have to change the XSL that transforms the result.

If a mail is not sent, it should not stop sending all the others, unless a SAXException is received (in that case the pipeline is probably broken, so there's nothing cocoon can do about it). Maybe you've seen it stopping because of the inconsistent XML, which caused a SAXException, which stops everything.

P.S. this patch is not a delta from the previous one, so you should revert the file on which you applied the previous patch and the apply this one on the clean reverted file.

> SendMailTransformer misses closing tag when recipient address is malformed
> --------------------------------------------------------------------------
>
>          Key: COCOON-1818
>          URL: http://issues.apache.org/jira/browse/COCOON-1818
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Mail
>     Reporter: Jasha Joachimsthal
>  Attachments: sendmail-exceptions.diff, sendmail-exceptions2.diff
>
> When a recipient address contains an illegal character (, ; <space> a@b@com etc), an exception is being thrown by method sendMail(List newAddresses, Transport trans).
> The execution of the try in method sendMail() is stopped which may have created a <email:result> tag. 
> No </email:result> end tag is created when this occurs.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira