cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Wechner <michael.wech...@wyona.com>
Subject [2.1.x] Patching enable-uploads during build
Date Thu, 16 Mar 2006 08:47:44 GMT
Hi

I have modified

build.properties
src/webapp/WEB-INF/web.xml

in order that one can actually patch the enable-uploads.

Before my change one had always true for this no matter if one declared
within (local.)build.properties: config.enable-uploads=false, because
web.xml was set to true by default and xpatch with if-prop won't patch 
if the prop is set to false.

So it works now, BUT I think the default setting within build.properties 
should be false and not true for
security reasons, but I left the default behaviour as it was, because I 
don't know what was agreed on.

Also I think one should enhance the xpatch such one can patch "several" 
times, because the way it works now
is that if you patch it with true, then one cannot patch it to false 
anymore. It's basically a "one way value patch".

Thanks

Michi

-- 
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
michael.wechner@wyona.com                        michi@apache.org


Mime
View raw message