cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Max Pfingsthorn (JIRA)" <>
Subject [jira] Commented: (COCOON-1794) [PATCH] Propagation of namespaces to a repeaters child bindings and implementation of a move-node binding
Date Wed, 08 Mar 2006 12:37:40 GMT
    [ ] 

Max Pfingsthorn commented on COCOON-1794:

Okay, fine. They only thing I would like to accomplish, and which is important to VNU and
Hippo as well, is that this repeater would work without an enclosing element for the rows.
This is currently not the case, and this is also not fixed by your patch. Actually, your patch
will make it worse as you assume that the parent element will only have the repeater's rows
as children. If you just move a row element after the ith element of the parent, bad things
can happen (in terms of document validity).

Our concern is to have a schema validateable output from cforms. This includes namespaces
and element ordering, especially with repeaters without their own parent element. Imagine
something like this:

       <p>some paragraph</p>
       <p>some other paragraph</p>

For the content and link elements, we want to use a repeater and not have contents after links
in the output, which does happen now. I've been thinking about it myself, and your patch just
seemed like a good idea to discuss a little.

Actually, now, the only thing that we have to do to fix this is to make an InsertAfterNodeJXPathBinding,
and in the loop where new rows get inserted, use that one which takes the previous row's node
and inserts a node after that one. This way, we will keep everything neatly aligned and no
moving is necessary, right?

> [PATCH] Propagation of namespaces to a repeaters child bindings and implementation of
a move-node binding
> ---------------------------------------------------------------------------------------------------------
>          Key: COCOON-1794
>          URL:
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Suzan Foster
>  Attachments: repeater-binding-patch.txt
> This patch corrects the following issues:
> - Namespaced back-end XML model not correctly binding to the repeaters child widgets.
> - Nodes bound to row widgets not being reordered according to row position on save.
> Files affected:
> - JXPathBindingBase:
>   - member applyLeniency changed from private to protected.
>   - member applyNSDeclarations changed from private to protected.
> - RepeaterJXPathBinding:
>   - constructor changed for passing a binding for moveRow.
>   - applyLeniency and applyNSDeclarations applied to created relative contexts.
>   - member moveRowBinding added.
>   - method getMoveRowBinding added.
>   - doSave changed to incorporate the use of moveRowBinding.
> - RepeaterJXPathBindingBuilder:
>   - buildBinding changed to incorporate the construction of moveRowBinding.
> Files added:
> - MoveNodeJXPathBinding.
> - MoveNodeJXPathBindingBuilder.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message