cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suzan Foster (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-1794) [PATCH] Propagation of namespaces to a repeaters child bindings and implementation of a move-node binding
Date Wed, 08 Mar 2006 11:42:59 GMT
    [ http://issues.apache.org/jira/browse/COCOON-1794?page=comments#action_12369431 ] 

Suzan Foster commented on COCOON-1794:
--------------------------------------

You can't do this in a single iteration. You don't know which nodes are marked for deletion
untill you have done your first pass seeing as the deletion criterium is 'not bound to a row'.
If you look at the current code you will see that it doesn't call deleteRowBinding.saveFormToModel(row,context)
but deleteRowBinding.saveFormToModel(repeater,context). Also your pseudocode still doesn't
take positioning into account save for newly inserted nodes. I believe it is better to be
pragmatic in solving this issue instead of how you would rather do it. 

> [PATCH] Propagation of namespaces to a repeaters child bindings and implementation of
a move-node binding
> ---------------------------------------------------------------------------------------------------------
>
>          Key: COCOON-1794
>          URL: http://issues.apache.org/jira/browse/COCOON-1794
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8, 2.1.9-dev (current SVN)
>     Reporter: Suzan Foster
>  Attachments: repeater-binding-patch.txt
>
> This patch corrects the following issues:
> - Namespaced back-end XML model not correctly binding to the repeaters child widgets.
> - Nodes bound to row widgets not being reordered according to row position on save.
> Files affected:
> - JXPathBindingBase:
>   - member applyLeniency changed from private to protected.
>   - member applyNSDeclarations changed from private to protected.
> - RepeaterJXPathBinding:
>   - constructor changed for passing a binding for moveRow.
>   - applyLeniency and applyNSDeclarations applied to created relative contexts.
>   - member moveRowBinding added.
>   - method getMoveRowBinding added.
>   - doSave changed to incorporate the use of moveRowBinding.
> - RepeaterJXPathBindingBuilder:
>   - buildBinding changed to incorporate the construction of moveRowBinding.
> Files added:
> - MoveNodeJXPathBinding.
> - MoveNodeJXPathBindingBuilder.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message