Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 64274 invoked from network); 9 Feb 2006 11:05:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 9 Feb 2006 11:05:25 -0000 Received: (qmail 94765 invoked by uid 500); 9 Feb 2006 11:05:21 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 94735 invoked by uid 500); 9 Feb 2006 11:05:20 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 94723 invoked by uid 99); 9 Feb 2006 11:05:20 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Feb 2006 03:05:20 -0800 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id 27C31CB for ; Thu, 9 Feb 2006 12:04:59 +0100 (CET) Message-ID: <1039683174.1139483099160.JavaMail.jira@ajax.apache.org> Date: Thu, 9 Feb 2006 12:04:59 +0100 (CET) From: "Jean-Baptiste Quenot (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Commented: (COCOON-1066) [PATCH] LDAPTransformer enhancements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/COCOON-1066?page=3Dcomments#acti= on_12365711 ]=20 Jean-Baptiste Quenot commented on COCOON-1066: ---------------------------------------------- Reading the code, I'm wondering why "AttributesImpl attr" is constructed on= ly once for all search results. Javadoc for AttributesImpl says that =C2= =AB this method does no checking to see if the attribute is already in the = list: that is the responsibility of the application =C2=BB See http://java.sun.com/j2se/1.5.0/docs/api/org/xml/sax/helpers/AttributesI= mpl.html#addAttribute(java.lang.String,%20java.lang.String,%20java.lang.Str= ing,%20java.lang.String,%20java.lang.String) Am I wrong? > [PATCH] LDAPTransformer enhancements > ------------------------------------ > > Key: COCOON-1066 > URL: http://issues.apache.org/jira/browse/COCOON-1066 > Project: Cocoon > Type: Improvement > Components: Blocks: Naming > Versions: 2.1.8 > Environment: Operating System: All > Platform: All > Reporter: David L. Day > Assignee: Jean-Baptiste Quenot > Priority: Minor > Attachments: LDAPTransformer.java.diff, LDAPTransformer.java.patch > > This patch addresses 2 issues through the addition of 2 elements in the > LDAPTransformer (LDAPTransformer.java): > dn-element: > Provide element containing the DN for each entry returned in 'execute-que= ry'.=20 > This is accomplished via 'dn-element' element that defaults to 'dn'. Thi= s > element is only valid in 'execute-query'. > securityprotocol: > Provide a mechanism for those using JDK prior to 1.4.2 to access LDAP via= SSL.=20 > This is accomplished via an optional 'securityprotocol' element that is e= mpty > (unused) by default. Please see > http://java.sun.com/products/jndi/tutorial/ldap/security/ssl.html for mor= e > information on the JDK differences WRT LDAP via SSL. --=20 This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira