cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Crossley (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COCOON-1402) [Patch] Cocoon incorrectly handles form encoding when form is passed as "multipart/form-data"
Date Wed, 01 Mar 2006 07:34:39 GMT
     [ http://issues.apache.org/jira/browse/COCOON-1402?page=all ]

David Crossley updated COCOON-1402:
-----------------------------------

    Bugzilla Id:   (was: 33013)
     Other Info: [Patch available]
    Description: 
Cocoon incorrectly handles form encoding when form is passed as
"multipart/form-data" and the encoding is configured with parameters in web.xml 
eg.
		 <init-param>
				<param-name>container-encoding</param-name>
				<param-value>ISO-8859-1</param-value>
		 </init-param>	   
		 <init-param>
				 <param-name>form-encoding</param-name>
				 <param-value>utf-8</param-value>
		 </init-param>


things work fine with normal url-encoded forms but when multipart form is
submitter encoding isn't handled properly. 

this bug can be easily fixed by replacing 
        this.requestFactory = new RequestFactory(this.autoSaveUploads,
                                                 this.uploadDir,
                                                 this.allowOverwrite,
                                                 this.silentlyRename,
                                                 this.maxUploadSize,
                                                 this.defaultFormEncoding);

with 
        this.requestFactory = new RequestFactory(this.autoSaveUploads,
                                                 this.uploadDir,
                                                 this.allowOverwrite,
                                                 this.silentlyRename,
                                                 this.maxUploadSize,
                                                 this.containerEncoding);

i.e.
this.defaultFormEncoding => this.containerEncoding

in CocoonServlet.java file line 473.

  was:
Cocoon incorrectly handles form encoding when form is passed as
"multipart/form-data" and the encoding is configured with parameters in web.xml 
eg.
		 <init-param>
				<param-name>container-encoding</param-name>
				<param-value>ISO-8859-1</param-value>
		 </init-param>	   
		 <init-param>
				 <param-name>form-encoding</param-name>
				 <param-value>utf-8</param-value>
		 </init-param>


things work fine with normal url-encoded forms but when multipart form is
submitter encoding isn't handled properly. 

this bug can be easily fixed by replacing 
        this.requestFactory = new RequestFactory(this.autoSaveUploads,
                                                 this.uploadDir,
                                                 this.allowOverwrite,
                                                 this.silentlyRename,
                                                 this.maxUploadSize,
                                                 this.defaultFormEncoding);

with 
        this.requestFactory = new RequestFactory(this.autoSaveUploads,
                                                 this.uploadDir,
                                                 this.allowOverwrite,
                                                 this.silentlyRename,
                                                 this.maxUploadSize,
                                                 this.containerEncoding);

i.e.
this.defaultFormEncoding => this.containerEncoding

in CocoonServlet.java file line 473.


> [Patch] Cocoon incorrectly handles form encoding when form is passed as "multipart/form-data"
> ---------------------------------------------------------------------------------------------
>
>          Key: COCOON-1402
>          URL: http://issues.apache.org/jira/browse/COCOON-1402
>      Project: Cocoon
>         Type: Bug
>   Components: * Cocoon Core
>     Versions: 2.1.8
>  Environment: Operating System: Windows XP
> Platform: PC
>     Reporter: blazej
>     Assignee: Cocoon Developers Team

>
> Cocoon incorrectly handles form encoding when form is passed as
> "multipart/form-data" and the encoding is configured with parameters in web.xml 
> eg.
> 		 <init-param>
> 				<param-name>container-encoding</param-name>
> 				<param-value>ISO-8859-1</param-value>
> 		 </init-param>	   
> 		 <init-param>
> 				 <param-name>form-encoding</param-name>
> 				 <param-value>utf-8</param-value>
> 		 </init-param>
> things work fine with normal url-encoded forms but when multipart form is
> submitter encoding isn't handled properly. 
> this bug can be easily fixed by replacing 
>         this.requestFactory = new RequestFactory(this.autoSaveUploads,
>                                                  this.uploadDir,
>                                                  this.allowOverwrite,
>                                                  this.silentlyRename,
>                                                  this.maxUploadSize,
>                                                  this.defaultFormEncoding);
> with 
>         this.requestFactory = new RequestFactory(this.autoSaveUploads,
>                                                  this.uploadDir,
>                                                  this.allowOverwrite,
>                                                  this.silentlyRename,
>                                                  this.maxUploadSize,
>                                                  this.containerEncoding);
> i.e.
> this.defaultFormEncoding => this.containerEncoding
> in CocoonServlet.java file line 473.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message