cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bart Molenkamp (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-1238) Improvements for CustomJXPathBinding
Date Thu, 02 Feb 2006 13:47:03 GMT
    [ http://issues.apache.org/jira/browse/COCOON-1238?page=comments#action_12364955 ] 

Bart Molenkamp commented on COCOON-1238:
----------------------------------------

The patch looks good to me. If I look at the files that I have here, they don't look the same
as those that I uploaded. I guess I uploaded the wrong files, sorry. Your patch looks pretty
much to what I have here, most important is that the statement 'jxpc.getRelativeContext(jxpc.getPointer(this.xpath))'
is gone, and is left to the custom binding (this was causing crashes at the time).

I do think that this patch breaks backward compatibility, I don't know if that's a big problem.

> Improvements for CustomJXPathBinding
> ------------------------------------
>
>          Key: COCOON-1238
>          URL: http://issues.apache.org/jira/browse/COCOON-1238
>      Project: Cocoon
>         Type: Improvement
>   Components: Blocks: Forms
>     Versions: 2.1.5
>  Environment: Operating System: All
> Platform: All
>     Reporter: Bart Molenkamp
>     Assignee: Jean-Baptiste Quenot
>     Priority: Minor
>  Attachments: 20060201-cocoon-forms-1238, AbstractCustomBinding.java.patch, CustomJXPathBinding.java.patch,
CustomJXPathBindingBuilder.java, CustomJXPathBindingBuilder.java.patch
>
> 2 improvements:
> 1. Custom bindings get a service manager when they implement Serviceable.
> 2. Relative JXPath context is not created. Instead, the current context, and the
> xpath query are passed to the custom binding. This allows bindings to set values
> for objects that are null (whereas a getRelativeContext() will throw an
> exception). Custom bindings now can do a
> context.createPathAndSetValue(getXpath(), ...) to set a value that was null
> before setting it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message