cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: svn commit: r377171 - in /cocoon/trunk/cocoon-portal/cocoon-portal-impl/src/main/java/org/apache/cocoon/portal: pluto/ profile/ profile/impl/
Date Mon, 13 Feb 2006 09:23:26 GMT
Ralph Goers wrote:
> 
>>>
>>> Item item = getParent().getParent();
>>> if (item == null || !(item instanceof NamedItem)) {
>>>     this.label = this.name;
>>> } else {
>>>     this.label = item.getLabel() + "." + this.name;
>>> }
>>>
>>>     
>>   
> I would create a setLabel method to NamedItem (probably protected or 
> even private) and then have setName() call it.
Ok, sounds good to me - I'll change that today. Don't we need a loop in
the code you provided above? For example if there sub tabs are not
directly nested inside the main tab?

Carsten

-- 
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/

Mime
View raw message