cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Gianni (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-1685) Additional ProcessingPhase.READ_FROM_REQUEST_VALUE event sent
Date Mon, 20 Feb 2006 15:12:25 GMT
    [ http://issues.apache.org/jira/browse/COCOON-1685?page=comments#action_12367041 ] 

Simone Gianni commented on COCOON-1685:
---------------------------------------

Added a PROCESS_INITIALIZE event type, now this event is broadcasted as the first event. 

Note that LOAD_MODEL and SAVE_MODEL are not used. LOAD_MODEL was incorrectly broadcasted instead
of the new event i added, while SAVE_MODEL seems to have no references. I suppose this events
should be broadcasted when a binding is applied.

> Additional ProcessingPhase.READ_FROM_REQUEST_VALUE event sent
> -------------------------------------------------------------
>
>          Key: COCOON-1685
>          URL: http://issues.apache.org/jira/browse/COCOON-1685
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8
>     Reporter: Simone Gianni
>  Attachments: process_initialize.diff
>
> In the Form.process() method, there is a listener.phaseEnded on line 296 which sends
a LOAD_MODEL_VALUE the first time the form is executed, and a READ_FROM_REQUEST_VALUE all
the other times. If a ProcessingPhaseListener is registered it will receive a READ_FROM_REQUEST_VALUE
before the request has been processed, and another one after.
> IMMO there are the following possible solutions :
> - remove this event broadcast.
> - send this event only if phase is LOAD_MODEL_VALUE, so that this event takes his chance
to get broadcasted, while the spurious one doesn't.
> - add a "PROCESS_INITIALIZED" phase event and send this one at this point.
> I can produce the patch if needed, but don't know which solution is the best one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message