Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 54909 invoked from network); 24 Jan 2006 21:03:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 24 Jan 2006 21:03:35 -0000 Received: (qmail 3960 invoked by uid 500); 24 Jan 2006 21:03:32 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 3890 invoked by uid 500); 24 Jan 2006 21:03:31 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 3879 invoked by uid 99); 24 Jan 2006 21:03:31 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2006 13:03:31 -0800 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id 73045E0 for ; Tue, 24 Jan 2006 22:03:10 +0100 (CET) Message-ID: <315786207.1138136590468.JavaMail.jira@ajax.apache.org> Date: Tue, 24 Jan 2006 22:03:10 +0100 (CET) From: "Antonio Fiol (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Commented: (COCOON-1681) Generator "directory": Caching too much In-Reply-To: <713003975.1131368240215.JavaMail.jira@ajax.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/COCOON-1681?page=comments#action_12363884 ] Antonio Fiol commented on COCOON-1681: -------------------------------------- Still an issue on 2.1.8, and still an issue in our project. We are testing --we started this week-- a patch doing exactly what is said in the description (one line removal). So far, it is working for us. Maybe it is not the most efficient solution, but has not shown performance problems either (in some parts of the project, we work with depth=6, with quite a lot of files and directories). Please bear with our long times. I hope I will confirm our results by the end of this week. > Generator "directory": Caching too much > --------------------------------------- > > Key: COCOON-1681 > URL: http://issues.apache.org/jira/browse/COCOON-1681 > Project: Cocoon > Type: Bug > Components: * Cocoon Core > Versions: 2.1.8, 2.1.7 > Reporter: Antonio Fiol > Assignee: Cocoon Developers Team > > In some cases, an update to the directory is not detected by the DirectoryGenerator. > Debugging the issue, I discovered that isValid() is called twice on the same DirValidity, but it returns different values (-1 the first time, 1 the second time). > Apparently, the reason for the inconsistency would be solved by removing the first of the two lines that update the expiry time in the isValid() method in DirValidity, but I am not sure whether this could cause problems in other places. > A possibility would be that a DirValidity stores the fact that it already detected it is invalid, and is changed so that it always return -1. But... Are DirValidity objects reused? Could this change cause problems? I have not tested, so I don't know. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira